VideoStreamPlayer has Expand enabled by default, causing it to be sized at 0×0 by default (therefore being invisible)

[lszl84]

Godot version: master (947a663)

OS/device including version: mac OS 10.15.3

Issue description: Video does not play in Godot 4. Works in Godot 3.

Steps to reproduce: Open attached project in Godot 3.2. Run it and verify that the video is playing. Close the project and open it in Godot 4. No video is being played when running the project.

Minimal reproduction project:
godot3vid-3.zip

[hungrymonkey]

ERROR: Condition "texture.is_null()" is true.
   at: update (scene/resources/texture.cpp:196)
ERROR: Condition "texture.is_null()" is true.
   at: update (scene/resources/texture.cpp:196)
ERROR: Condition "texture.is_null()" is true.
   at: update (scene/resources/texture.cpp:196)
ERROR: Condition "texture.is_null()" is true.
   at: update (scene/resources/texture.cpp:196)
ERROR: Condition "texture.is_null()" is true.
   at: update (scene/resources/texture.cpp:196)
ERROR: Condition "texture.is_null()" is true.
   at: update (scene/resources/texture.cpp:196)
ERROR: Condition "texture.is_null()" is true.
   at: update (scene/resources/texture.cpp:196)
ERROR: Condition "texture.is_null()" is true.
   at: update (scene/resources/texture.cpp:196)
ERROR: Condition "texture.is_null()" is true.
   at: update (scene/resources/texture.cpp:196)
ERROR: Condition "texture.is_null()" is true.
   at: update (scene/resources/texture.cpp:196)
ERROR: Condition "texture.is_null()" is true.
   at: update (scene/resources/texture.cpp:196)
ERROR: Condition "texture.is_null()" is true.
   at: update (scene/resources/texture.cpp:196)
ERROR: Condition "texture.is_null()" is true.
   at: update (scene/resources/texture.cpp:196)
ERROR: Condition "texture.is_null()" is true.
   at: update (scene/resources/texture.cpp:196)

bug_video 2.zip

I can hear sound but the video does not work.

[Jayman2000]

I don’t think that this issue is still valid. See:

• Move video playback out of core and into an officially supported GDExtension godot-proposals#3286
• Remove WebM support (and deps libvpx and opus) #53833

[Calinou]

@Jayman2000 Theora is still supported in master – it's just that WebM support was removed in master.

[Calinou]

I can hear sound but the video does not work.

This is because the VideoStreamPlayer node has a rect size of 0×0, causing it to be invisible. Disable the Expand property on the VideoStreamPlayer node, or set the Layout to Full Rect (will cause aspect ratio distortion unless the video's aspect ratio matches).¹

The same applies to @lszl84's minimal reproduction project.

I suggest fixing this by disabling the Expand property by default on VideoStreamPlayer in 4.0, but we can't do this in 3.x to avoid breaking compatibility with existing projects. It may also be worth adding similar scaling options as TextureRect:

Additionally, we can add a node configuration warning if a Control node's rect size is 0 pixels on either the X or Y axis (which will make it invisible). This is something we can also add to 3.x.

Footnotes

1. To preserve the aspect ratio on wider window aspect ratios, set the Layout to Full Rect, then use the Anchors Only submenu to set the anchors to VCenter Wide. ↩