Remove WebM support (and deps libvpx and opus) #53833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had many issues with WebM support and specifically the libvpx library over the years, mostly due to its poor integration in Godot's buildsystem, but without anyone really interested in improving this state. With the new GDExtensions in Godot 4.0, we intend to move video decoding to first-party extensions, and this would likely be done using something like libvlc to expose more codecs. Removing the `webm` module means we can remove libsimplewebm, libvpx and opus, which we were only used for that purpose. Both libvpx and opus were fairly complex pieces of the buildsystem, so this is a nice cleanup. This also removes the compile-time dependency on `yasm`. Fixes lots of compilation or non-working WebM issues which will be linked in the PR.
akien-mga
added a commit
to akien-mga/godot-docs
that referenced
this pull request
Oct 15, 2021
WebM support is dropped from the core engine with godotengine/godot#53833
aaronfranke
approved these changes
Oct 15, 2021
This was referenced Dec 25, 2021
rsubtil
pushed a commit
to rsubtil/godot-docs
that referenced
this pull request
Apr 11, 2023
WebM support is dropped from the core engine with godotengine/godot#53833
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had many issues with WebM support and specifically the libvpx library
over the years, mostly due to its poor integration in Godot's buildsystem,
but without anyone really interested in improving this state.
With the new GDExtensions in Godot 4.0, we intend to move video decoding to
first-party extensions, and this would likely be done using something like
libvlc to expose more codecs.
Removing the
webmmodule means we can remove libsimplewebm, libvpx andopus, which we were only used for that purpose. Both libvpx and opus were
fairly complex pieces of the buildsystem, so this is a nice cleanup.
This also removes the compile-time dependency on
yasm.For now I kept the Theora plugin, as it's much simpler/better integrated in
our buildsystem, so it can still be useful until we actually provide a
GDExtension option that can be used in production.
For the record, this naturally makes the compiled binaries somewhat smaller,
though nothing huge. Current Linux release export template with LTO goes from
53.83 MiB to 53.05 MiB (so ~800 KiB reduction).
Closes #8334.
Closes #13272.
Closes #19319.
Closes #30333.
Closes #30914.
Closes #33472.
Closes #34660.
Closes #37648.
Closes #39178.
Closes #42698.
Closes #44706.
Closes #50862.
Closes #51951.
Related to godotengine/godot-proposals#3286.