Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LSP] Diagnostics are not cleared out when a file is deleted. #43133

Closed
linkpy opened this issue Oct 27, 2020 · 1 comment · Fixed by #47776
Closed

[LSP] Diagnostics are not cleared out when a file is deleted. #43133

linkpy opened this issue Oct 27, 2020 · 1 comment · Fixed by #47776

Comments

@linkpy
Copy link
Contributor

linkpy commented Oct 27, 2020

Godot version:
3.2.3

OS/device including version:
Linux 5.4.0 (Linux Mint)

Issue description:
The LSP implementation doesn't seem to detect file deletion and thus doesn't clear out the diagnostics of that file.

Linked to godotengine/godot-vscode-plugin#243.
The LSP specification specifies that the creator of the diagnostics is responsible for their deletion (see microsoft/language-server-protocol#463).

Steps to reproduce:
Create a new file, write anything invalid in it then save (not saving the file then closing clears out the diagnostics).
Delete the file, notice the diagnostics are still here.

Minimal reproduction project:

@akien-mga
Copy link
Member

Fixed in 3.3 by #47553, but not fixed in master yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants