Disconection betwen Gizmo and inspector values on BakedLightmap

[Janders1800]

Godot version:

3.2.4-beta6

OS/device including version:

Zorin OS 15

Issue description:

If you change Extents in the Gizmo it does not reflects on the inspector.

@JFonS related: #44628

Steps to reproduce:
Add a BackedLightmap node and change its extents with the gizmo.

Minimal reproduction project:

No need.

[Calinou]

A change_notify("extents") call was likely missed in the gizmo code.

[Bhu1-V]

I actually tried to fix this, but I didn't see neither the gizmos nor those values available in the inspector. using this version ad0f1c6

[Calinou]

I actually tried to fix this, but I didn't see neither the gizmos nor those values available in the inspector. using this version ad0f1c6

The master branch has a different GPU-based lightmapper which doesn't have a notion of extents. You need to test this with the 3.2 branch on a different project.

[TamplierS1]

Hi, I fixed this by adding _change_notify("extents") to _update_gizmo() method in Spatial class. Do I create a pull request to 3.2 branch or master branch?

[Calinou]

Hi, I fixed this by adding _change_notify("extents") to _update_gizmo() method in Spatial class. Do I create a pull request to 3.2 branch or master branch?

To me, it seems too "general" to add this to the Spatial class. Solutions must be local, so the fix should be applied to the BakedLightmap class.

Also, since BakedLightmap extents only exist in Godot 3.2.x, the pull request should be opened against the 3.2 branch.

[TamplierS1]

Okay, I moved _change_notify("extents") to set_extents() in BakedLightmap and opened a PR on 3.2 #45510

[akien-mga]

Fixed by #45510.