Fix disconnection between Gizmo and inspector values on BakedLightmap #45510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Jan 27, 2021
scene/3d/baked_lightmap.cpp
Outdated
| @@ -1055,6 +1055,7 @@ float BakedLightmap::get_capture_cell_size() const { | |||
| void BakedLightmap::set_extents(const Vector3 &p_extents) { | |||
| extents = p_extents; | |||
| update_gizmo(); | |||
| _change_notify("extents"); | |||
| _change_notify("bake_extents"); | |||
There was a problem hiding this comment.
Should _change_notify("bake_extents"); below be removed? I guess the bake_extents property was renamed to extents, making that line no longer relevant.
There was a problem hiding this comment.
That makes sense. I removed it from set_extents()
|
Could you squash the two commits into one? See PR workflow. |
After adding `_change_notify("extents");` to `set_extents()` method in `BakedLightmap` class
the issue was fixed
Fix disconnection between Gizmo and inspector values on BakedLightmap
Remove unnecessary `_change_notify("bake_extents")` call from `set_extents()`
akien-mga
approved these changes
Jan 28, 2021
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding
_change_notify("extents");toset_extents()method inBakedLightmapclassthe issue was fixed
Bugsquad edit: This closes #45317.