Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing inherited methods in the "Select Method" window for animation call method tracks for C# scripts. #46408

Closed
Gawehold opened this issue Feb 25, 2021 · 2 comments · Fixed by #52607
Closed

Missing inherited methods in the "Select Method" window for animation call method tracks for C# scripts. #46408

Gawehold opened this issue Feb 25, 2021 · 2 comments · Fixed by #52607
Labels
bug topic:dotnet topic:editor
Milestone
4.0

Comments

@Gawehold
Copy link

Godot version:

3.2.3.stable.mono and 3.2.4.rc3.mono

OS/device including version:

OS: Windows 10 64bit
Backend: GLES3
GPU: GTX 1060 6GB

Issue description:

When adding a new method call key to a "call method track", there is a popup window listing all methods of the node.
However, the "Script Methods" section only includes the methods in the script file, not those inherited from its parent class.
This issue is similar to #23384, which seems to be fixed, but the scripts I use are C# scripts instead of GDScripts.

Steps to reproduce:

  1. Create a class A with a public/protected method X in a C# script A.cs
  2. Create a class B that inherit class A in another C# script B.cs
  3. Attach B.cs to arbitrary node in a arbitrary scene.
  4. Create an AnimationPlayer node in the same scene.
  5. Create an animation and a "call method track" of the node with B.cs attached.
  6. Insert a new key in the track
  7. Method X is not listed in the popup window

Minimal reproduction project:
@Calinou
Copy link
Member

Calinou commented Feb 25, 2021

Related to #39156 and #37803.

paulloz added a commit to paulloz/godot that referenced this issue Sep 12, 2021
@paulloz
Improve C# method listing
19f25b6 
- implement CSharpInstance::get_method_list
- loop through parent classes in CSharpInstance::get_method_list and CSharpScript::get_script_method_list (godotengine#46408)
@paulloz paulloz mentioned this issue Sep 12, 2021
Merged
@akien-mga akien-mga added this to the 4.0 milestone Sep 13, 2021
@akien-mga
Copy link
Member

Fixed by #52607.

akien-mga pushed a commit to akien-mga/godot that referenced this issue Sep 14, 2021
@paulloz @akien-mga
Improve C# method listing
e2b71de 
- implement CSharpInstance::get_method_list
- loop through parent classes in CSharpInstance::get_method_list and CSharpScript::get_script_method_list (godotengine#46408)

(cherry picked from commit 19f25b6)
sairam4123 pushed a commit to sairam4123/godot that referenced this issue Nov 10, 2021
@paulloz @sairam4123
Improve C# method listing
f4cb466 
- implement CSharpInstance::get_method_list
- loop through parent classes in CSharpInstance::get_method_list and CSharpScript::get_script_method_list (godotengine#46408)

(cherry picked from commit 19f25b6)
lekoder pushed a commit to KoderaSoftwareUnlimited/godot that referenced this issue Dec 18, 2021
@paulloz @lekoder
Improve C# method listing
ec810f9 
- implement CSharpInstance::get_method_list
- loop through parent classes in CSharpInstance::get_method_list and CSharpScript::get_script_method_list (godotengine#46408)

(cherry picked from commit 19f25b6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:dotnet topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Improve C# method listing paulloz/godot
3 participants
@Calinou @akien-mga @Gawehold