Running --doctool wrongly creates shader_cache directory in working directory
#49392
Labels
Milestone
Comments
akien-mga
added a commit
to akien-mga/godot
that referenced
this issue
Jun 16, 2021
WARNING: Hacks everywhere! The logic in `main.cpp` is due a full rewrite as it's extremely hacky, splitting argument parsing over several functions, with a mess of global state and assumptions about what combinations of arguments or lack thereof should mean in terms of what we want to read: game, editor, project manager, or command line tools such as `--doctool`, `--export` or `--script`. Until this is fully rewritten, this patch hacks things some more to ensure that we don't fall back to the project manager in cases where it's not warranted, and especially not *too late*, as it can mean that we haven't properly initialized stuff like `EditorPaths` needed by the PM (which in turn impacts what kind of path will be used for logs and the shader cache, etc... the rabbit hole goes deep). Fixes godotengine#41435. Fixes godotengine#49392. Fixes godotengine#49658. Fixes godotengine#38202 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Godot version:
master(896aa94)OS/device including version:
Mageia 9
Issue description:
When running
--doctool, ashader_cacherepository is created in the working directory, since the addition of shader caching in #49050.Normally running the editor should generate and use the
shader_cachein the editor config dir, but--doctoolis badly set up inmain.cppas neither really editor nor project manager nor standalone project, so the logic seems to fail here.This is similar to #41435 and would likely be fixed the same way (both bugs might be the same).
Steps to reproduce:
godot --doctoollsThe text was updated successfully, but these errors were encountered: