Moving elements in the editor's tree with drag-and-drop is broken

[TokageItLab]

Godot version

4.0.dev (88bf6e1)

System information

MacOS 11.4

Issue description

Dragging and dropping an element in the Editor tree does not move it correctly. The problem occurs both in Explorer and in the scene tree.

Steps to reproduce

Try to move elements in the tree by dragging and dropping them.

Minimal reproduction project

No response

[SirQuartz]

You're going to need to explain this a little better or provide a minimum reproduction project because I'm using 4.0 dev right now and not noticing any problems with moving elements within the scene tree.

[TokageItLab]

@SirQuartz For example, in this video, I expect the operation to put the CollisionShape into a child of the StaticBody, but it does not.

2021-07-22.8.36.17.mov

tree.zip

[SirQuartz]

That's very odd behavior on your end for some reason, because I just tested this exactly and didn't run into any problems, it behaved exactly as expected.

drag.drop.mp4

[TokageItLab]

It may have been broken in some recent commit, and it was certainly working correctly before.

[SirQuartz]

v4.0.dev (286e9b8)

I just compiled the engine within the last hour, try compiling again to the latest version, and see if that helps for some reason. Don't know why it would, but you never know.

[TokageItLab]

I tried the latest commit (a4c8637), but it was still broken. Also, I tried to change the language to English but did not improve the problem.
As for the behavior of the bug, it looks like the index is off by one... Is it possible that only Mac OS has this problem?

[SirQuartz]

I was just about to suggest that this might be a macOS specific problem too, as I'm currently running Windows 10. Either way, it's definitely very strange.

[Calinou]

@TokageItLab Can you reproduce this if Single Window Mode is enabled in the Editor Settings?

[akien-mga]

Might be a HiDPI issue? Maybe the offsets for drag and drop are visually correct but internally wrong so it ends up on the wrong target.

[TokageItLab]

@Calinou Yeah, The problem did not occur in Single Window Mode!

So, in without Single Window Mode, when I change the DisplayScale, tree elements cannot be moved and no longer work. It seems likely that there is some kind of problem with HiDpi.

[Calinou]

When single-window mode is disabled, it seems the editor's display scale is not applied to some non-main windows such as popups. In a running project, it won't apply to any subwindows if you use a stretch mode other than disabled.

[danger-dan]

Can confirm I have also just run into this issue with Windows 10 Desktop display scale of 175%. Also very likely related - when editing names/numbers (text input) a second text edit appears offset from the original input location. I can create a separate issue with screenshots - if desired - after work.

[KoBeWi]

Might be the same issue as #38312

[KoBeWi]

Is this still reproducible in alpha 8?

[TokageItLab]

Fixed!