Fix bad popups offset in editor with single window off

[jmb462]

Fix #47217

Issue description

When single window is disabled, popup menus in editor pops at a bad offset (see GIFs below)

Fix proposal (Updated after Kobewi comment)

Using get_screen_transform() instead of get_global_transform() to set the popup position to deal with offset in multiwindow mode correctly.

BEFORE

Bezier Editor bug

Script Editor bug

Shader Editor Bug

Curve editor bug

Canvas editor bug

AFTER

Bezier editor fixed

Script editor fixed

Shader Editor Fixed

Curve Editor Fixed

Canvas Editor Fixed

[KoBeWi]

This won't work if the control is rotated or scaled. It's not a problem in the editor, but e.g. TextEdit can't use this. The problem might lie in get_screen_transform() possibly returning wrong value.

[jmb462]

@KoBeWi get_screen_transform() is working well.

All buggy popup were using get_global_transform() instead.

I've modified the PR to replace these occurence.
A lot of other popups uses get_screen_transform() and works well.

[KoBeWi]

The change is good, but it doesn't fix all popups. I'd take the chance to replace all wrong usage of global position/transform. Also there are cases like e.g. ConnectionsDock, where the menu isn't properly trimmed:

Such popups need popup->set_size(Vector2()) call.

[groud]

This PR looks quite similar to #37506, but I am not sure that on e is still being worked on. You might want to have a look to it.

[jmb462]

This PR looks quite similar to #37506, but I am not sure that on e is still being worked on. You might want to have a look to it.

@groud All cases fixed by this PR are also fixed in #37506 with the same modifications and #37506 is more exhaustive.

I think we could close this one and "reactivate" the review process of #37506.

[YuriSizov]

@jmb462 If you are up for it, it would likely be preferable if you were to incorporate the changes from the other PR here, add that other contributor as co-author and see it through to the end. The other PR is a year old, they may not be ready to work on it right now. But you are here 🙃

[jmb462]

OK, I've included most of @giarve modification in this PR (from #37506).
I've also found one or two popups that still use get_global_transform() and fixed it.
I've added some default size to popup to ensure they are trimmed properly (each time I can't find set_size() for these popups)

BUT I didn't include @giarve modification for following files cause it wasn't clear to me :

• scene/main/window.cpp related to screen set current screen
• platform/linuxbsd/display_server_x11.cpp cause I don't understand this part

[KoBeWi]

Needs rebase, also set_size(Vector2(1, 1) needs to be changed to reset_size().
Is this finished aside from that?

[jmb462]

Needs rebase, also set_size(Vector2(1, 1) needs to be changed to reset_size(). Is this finished aside from that?

@KoBeWi Done. Seems finished to me.

[TokageItLab]

Does it fix to #50720? I guess that issue caused by same reason.

[jmb462]

Does it fix to #50720? I guess that issue caused by same reason.

No. It only deals with popups.

[KoBeWi]

So I accidentally opened an extremely similar PR 3 days ago, which has most of the changes that this one has. I made sure to go over every single popup, so you can take a look if your PR isn't missing something I did. I know that at least my changes to visual_shader_editor_plugin.cpp are still relevant, so you could just copy them over here.

[jmb462]

So I accidentally opened an extremely similar PR 3 days ago, which has most of the changes that this one has. I made sure to go over every single popup, so you can take a look if your PR isn't missing something I did. I know that at least my changes to visual_shader_editor_plugin.cpp are still relevant, so you could just copy them over here.

Done. I've completed this PR with some of your changes that were missing here.

[akien-mga]

I just created a new conflict by merging another PR, so needs a rebase.

[akien-mga]

I just created a new conflict by merging another PR, so needs a rebase.

I did it myself and force pushed the rebase so that we can get it merged.

[akien-mga]

For the record there's a few more places with get_global_transform().xform which might be worth reviewing, if they haven't been already:

$ rg "get_global_transform\(\).xform"
scene/3d/soft_dynamic_body_3d.cpp
403:                    PhysicsServer3D::get_singleton()->soft_body_move_point(physics_rid, r[i].point_index, r[i].spatial_attachment->get_global_transform().xform(r[i].offset));

scene/3d/visual_instance_3d.cpp
36:     return get_global_transform().xform(get_aabb());

scene/2d/node_2d.cpp
362:    return get_global_transform().xform(p_local);

editor/animation_track_editor.cpp
5229:                   box_selecting_from = scroll->get_global_transform().xform(mb->get_position());
5274:           Vector2 to = scroll->get_global_transform().xform(mm->get_position());

scene/3d/node_3d.cpp
757:    return get_global_transform().xform(p_local);

editor/plugins/node_3d_editor_plugin.cpp
6528:                                   aabb = collision_shape->get_global_transform().xform(collision_shape->get_shape()->get_debug_mesh()->get_aabb());
6534:                                           aabb.merge_with(col_shape->get_global_transform().xform(col_shape->get_shape()->get_debug_mesh()->get_aabb()));

[KoBeWi]

These are unrelated. The PR was only about popups. get_global_transform() is in window's local coordinates, but popups expect screen coordinates (get_screen_transform()).

[akien-mga]

Thanks!