Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollContainer internal ScrollBars exposed when saved as a separate scene #54960

Closed
rafallus opened this issue Nov 14, 2021 · 4 comments · Fixed by #61966
Closed

ScrollContainer internal ScrollBars exposed when saved as a separate scene #54960

rafallus opened this issue Nov 14, 2021 · 4 comments · Fixed by #61966

Comments

@rafallus
Copy link
Contributor

Godot version

Master ed300d7

System information

Arch Linux

Issue description

When using the 'Save Branch as Scene' option with a ScrollContainer, the saved scene shows the internal children of ScrollContainer, i.e. the horizontal and vertical scroll bars
ScrollContainer_bug

Steps to reproduce

  • Add ScrollContainer node to a scene
  • Select 'Save Branch as Scene' in the contextual menu from the node tree
  • Open the new scene

Minimal reproduction project

No response

@Calinou
Copy link
Member

Calinou commented Nov 14, 2021

This is likely a case that wasn't handled in #30391.

cc @KoBeWi

@KoBeWi
Copy link
Member

KoBeWi commented Nov 14, 2021

It doesn't look related to my PR. #30391 only made the scrollbars hidden from accessing via script. In the case here it seems like the editor is setting their owner for whatever reason.

@KoBeWi
Copy link
Member

KoBeWi commented Nov 16, 2021

This is regression from #45937
CC @revilo

@revilo
Copy link
Contributor

revilo commented Nov 29, 2021

@KoBeWi
I confirm, thanks for pointing out!
When I replaced the usage of duplicate_and_reown by duplicate_from_editor for "Save branch as scene" to fix #45937, I had to setup the node owners in the same way as duplicate_and_reown did previously. It seems that I haven't done it in the right way obviously. Will have a deeper look into this ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment