Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Lights with Bake Mode set to Static cause SDFGI to become infinitely bright as the camera moves #55322

Open
Tracked by #55327
Calinou opened this issue Nov 25, 2021 · 2 comments

Comments

@Calinou
Copy link
Member

Calinou commented Nov 25, 2021

Godot version

4.0.dev (5efe80f)

System information

Fedora 34, GeForce GTX 1080 (NVIDIA 470.74)

Issue description

Lights with Bake Mode set to Static cause SDFGI to become indefinitely bright as the camera moves.

By default, lights in Godot are configured to have their bake mode set to Dynamic, so this issue is unlikely to impact most users. Nonetheless, lights configured to use the Static bake mode likely offer better performance, especially with greater amounts of lights.

In the videos below, lights' energy is set to 0.1 and indirect energy is set to 10 to make the issue more obvious. SDFGI Bounce Feedback is left to its default setting (0) to avoid infinite feedback loops from SDFGI itself. Nonetheless, it still occurs with lights configured in Static bake mode when the camera moves enough to cause cascades to regenerate:

Lights with Static bake mode

simplescreenrecorder-2021-11-25_21.59.45.mp4

Lights with Dynamic bake mode

simplescreenrecorder-2021-11-25_22.00.08.mp4

Steps to reproduce

  • Create a scene with meshes that have their bake mode set to Static.
  • Add lights with their bake mode set to Static.

Minimal reproduction project

test_sdfgi_dynamic_vs_static.zip
Press Space to toggle between the scenes with lights that have Static and Dynamic bake mode. (In both scenes, the lights don't actually move over time.)

@Calinou Calinou added this to the 4.0 milestone Nov 25, 2021
@Calinou Calinou changed the title Vulkan: Lights with Bake Mode set to Static cause SDFGI to become indefinitely bright as the camera moves Vulkan: Lights with Bake Mode set to Static cause SDFGI to become infinitely bright as the camera moves Nov 25, 2021
@clayjohn clayjohn modified the milestones: 4.0, 4.x Feb 22, 2023
@Calinou
Copy link
Member Author

Calinou commented Oct 6, 2023

I can't reproduce this on 4.1.1.stable or 4.2.dev6 (Linux, NVIDIA 535.113.01), closing.

Static

simplescreenrecorder-2023-10-06_22.37.39.mp4

Dynamic

simplescreenrecorder-2023-10-06_22.38.00.mp4

@Calinou Calinou closed this as completed Oct 6, 2023
@Calinou Calinou modified the milestones: 4.x, 4.1 Oct 6, 2023
@Jay-Dorcat
Copy link

Jay-Dorcat commented Oct 23, 2023

I'm still getting this Issue in both 'v4.2.beta2.official [f8818f8]' and 'v4.1.2.stable.official [399c9dc]'
SDFGITest gif
Reproduction Projects :
Version 4.2.beta2 : SDFGITest4.2.zip
Version 4.1.2.stable : SDFGITest4.1.zip

@Calinou Calinou reopened this Oct 23, 2023
@Calinou Calinou removed this from the 4.1 milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants