-
-
Notifications
You must be signed in to change notification settings - Fork 21k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vulkan: Lights with Bake Mode set to Static cause SDFGI to become infinitely bright as the camera moves #55322
Labels
Comments
Calinou
changed the title
Vulkan: Lights with Bake Mode set to Static cause SDFGI to become indefinitely bright as the camera moves
Vulkan: Lights with Bake Mode set to Static cause SDFGI to become infinitely bright as the camera moves
Nov 25, 2021
I can't reproduce this on 4.1.1.stable or 4.2.dev6 (Linux, NVIDIA 535.113.01), closing. Staticsimplescreenrecorder-2023-10-06_22.37.39.mp4Dynamicsimplescreenrecorder-2023-10-06_22.38.00.mp4 |
I'm still getting this Issue in both 'v4.2.beta2.official [f8818f8]' and 'v4.1.2.stable.official [399c9dc]' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Godot version
4.0.dev (5efe80f)
System information
Fedora 34, GeForce GTX 1080 (NVIDIA 470.74)
Issue description
Lights with Bake Mode set to Static cause SDFGI to become indefinitely bright as the camera moves.
By default, lights in Godot are configured to have their bake mode set to Dynamic, so this issue is unlikely to impact most users. Nonetheless, lights configured to use the Static bake mode likely offer better performance, especially with greater amounts of lights.
In the videos below, lights' energy is set to 0.1 and indirect energy is set to 10 to make the issue more obvious. SDFGI Bounce Feedback is left to its default setting (0) to avoid infinite feedback loops from SDFGI itself. Nonetheless, it still occurs with lights configured in Static bake mode when the camera moves enough to cause cascades to regenerate:
Lights with Static bake mode
simplescreenrecorder-2021-11-25_21.59.45.mp4
Lights with Dynamic bake mode
simplescreenrecorder-2021-11-25_22.00.08.mp4
Steps to reproduce
Minimal reproduction project
test_sdfgi_dynamic_vs_static.zip
Press Space to toggle between the scenes with lights that have Static and Dynamic bake mode. (In both scenes, the lights don't actually move over time.)
The text was updated successfully, but these errors were encountered: