Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageTexture change Size in Editor no 2D preview update #5738

Closed
AlexHolly opened this issue Jul 16, 2016 · 4 comments
Closed

ImageTexture change Size in Editor no 2D preview update #5738

AlexHolly opened this issue Jul 16, 2016 · 4 comments

Comments

@AlexHolly
Copy link
Contributor

Changing the Size of an ImageTexture(Resource) in the Editor is not updating the 2D preview(you have to click on the sprite to update).

Adding this solves the issue.

https://github.com/godotengine/godot/blob/master/scene/resources/texture.cpp#L32

#include "core_string_names.h"

https://github.com/godotengine/godot/blob/master/scene/resources/texture.cpp#L140

emit_signal(CoreStringNames::get_singleton()->changed);

I am not sure what " _change_notify();" does, maybe this has to be added too.

Is it even wise to change the size of an ImageTexture in the Editor?

I can't see any effect:
1.The size changes are never saved.
1.1. Saving the resource after changing the size is only saving the old size.
1.2. Change the "ImageTexture" Size, press save resource, press save scene, restart project. the ImageTexture has the old size.
1.3. Exporting to an TileSet with the new size is also using the old size.

If this is something that should not be used is it possible to hide the settings?

@AlexHolly
Copy link
Contributor Author

1.In 3.0 New Image has no effect.

2.Using Load wants a .res file. I don't know how to get such a resource.
When I change the filter to "All Files(*)" and open a .png it crashes godot.

image

@akien-mga akien-mga added this to the 3.0 milestone Jul 19, 2017
@mhilbrunner
Copy link
Member

This seems to be fixed in Godot 3.0 beta 2. Can't reproduce, all of the above changed. Close?

@AlexHolly
Copy link
Contributor Author

  • 2D update preview: I don't know how I changed the size of the Resource I think this was fixed I can't see size properties in ImageTexture/StreamTexture.

  • 1. Is still showing "New Image" when you click it nothing happens what is the purpose?

  • 2. Godot is not crashing anymore but shows many errors so if loading a .png is not allowed maybe remove "All Files(*)" selection?

@akien-mga
Copy link
Member

We have now entered release freeze for Godot 3.0 and want to focus only on release critical issues for that milestone. Therefore, we're moving this issue to the 3.1 milestone, though a fix may be made available for a 3.0.x maintenance release after it has been tested in the master branch during 3.1 development. If you consider that this issue is critical enough to warrant blocking the 3.0 release until fixed, please comment so that we can assess it more in-depth.

@akien-mga akien-mga modified the milestones: 3.0, 3.1 Jan 9, 2018
@reduz reduz closed this as completed in 317dee9 Jul 29, 2018
malcolmhoward pushed a commit to malcolmhoward/godot that referenced this issue Jul 31, 2018
malcolmhoward pushed a commit to malcolmhoward/godot that referenced this issue Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants