4.0 Custom Project Settings with feature tags are displayed incorrectly

[Lielay9]

Godot version

4.0alpha6

System information

Windows 10 Vulkan, Nvidia 1050TI (Reproduced on desktop 2080TI)

Issue description

Expected:

Got:

Names are only displayed incorrectly; the project.godot-file has correct names, the tooltips use correct paths and the settings can be referred from the expected paths from code. Based on a quick test it seems that all tags produce similar results depending on their length.

Also a relevant comment from @Calinou:

This is likely a regression from godotengine/godot#58706 ... I've been able to reproduce this too but I don't know exactly why it's broken.

Also also. When trying to reproduce this bug, I found out that the reset-icons next to the custom project settings don't reset the value to the default variable value but instead delete the setting altogether. (In 3.x there are no reset-icons). If not linked to this issue, then perhaps another bug.

Steps to reproduce

Add a custom project setting that has a feature tag. (.windows, .android etc.)

Minimal reproduction project

No response

[Calinou]

cc @timothyqiu

[Rindbee]

May be related to the code here.

godot/editor/editor_inspector.cpp

Lines 2679 to 2688 in 690fefe

	// Get the property label's string.
	String name_override = (path.contains("/")) ? path.substr(path.rfind("/") + 1) : path;
	String feature_tag;
	{
	const int dot = name_override.find(".");
	if (dot != -1) {
	feature_tag = name_override.right(dot);
	name_override = name_override.substr(0, dot);
	}
	}

feature_tag = name_override.right(dot); 

Here should be the substring to the right of the "."

[timothyqiu]

@Rindbee Yeah, the behavior of right() changed on master. This is a cherry-pick mistake I made :(

[Rindbee]

Darkening of the labels also seems to be an issue.

[timothyqiu]

The label is darkened when it's an override. When the dot is lost (due to the right() mistake), it's not darkened.