Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Reload Current Project" prompts the user to open Project Manager #60783

Closed
Mickeon opened this issue May 5, 2022 · 6 comments
Closed

"Reload Current Project" prompts the user to open Project Manager #60783

Mickeon opened this issue May 5, 2022 · 6 comments

Comments

@Mickeon
Copy link
Contributor

Mickeon commented May 5, 2022

Godot version

3.5 Beta 5

System information

Windows 10

Issue description

Reloading the current project asks the user if they want to open the Project Manager, despite it having not much to do with the operation.
bfdb3880b6d18810abfd0756d8fdc9bc

Clicking on "Yes" reloads the project just fine, without ever showing the Project Manager.

This does not happen in Godot 3.3.3. The project reloads without any prompt.

Steps to reproduce

Click on Project on the top-left, then click on "Reload Current Project".

Minimal reproduction project

No need.

@Mickeon Mickeon changed the title "Reload Current Project" asks the user if they want to open Project Manager "Reload Current Project" prompts the user to open Project Manager May 5, 2022
@akien-mga
Copy link
Member

Looks like an off by one error, it's using the next action ("Quit to Project List").

@akien-mga
Copy link
Member

As identified in #60804 (comment) this is a regression from #59442, CC @Vitika9. The issue should also be fixed in master, not just in 3.x as attempted in #60804.

@RedHeadphone
Copy link
Contributor

RedHeadphone commented May 6, 2022

@akien-mga but this issue doesn't exist in master branch, am I missing something?
there is no confirmation on reload current project if all files are saved in master branch

@akien-mga
Copy link
Member

Alright, then the bug is specific to the cherry-pick of #59442, I might have missed that there were differences and that the master version would not work as is.

@RedHeadphone
Copy link
Contributor

RedHeadphone commented May 6, 2022

I might be wrong but this bug has nothing to with #59442 , the confirmation on 'reload project'/ 'run project manager' when files are saved was simply not from 3.x version (This #32321 wasn't merged in 3.x).

@akien-mga
Copy link
Member

Fixed by #60804.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants