fix: "Reload Current Project" prompts the user to open Project Manager #60804
Conversation
editor/editor_node.cpp
Outdated
| @@ -2715,7 +2715,7 @@ void EditorNode::_menu_option_confirm(int p_option, bool p_confirmed) { | |||
| bool confirm = EDITOR_GET("interface/editor/quit_confirmation"); | |||
| if (confirm) { | |||
| confirmation->get_ok()->set_text(p_option == FILE_QUIT ? TTR("Quit") : TTR("Yes")); | |||
| confirmation->set_text(p_option == FILE_QUIT ? TTR("Exit the editor?") : TTR("Open Project Manager?")); | |||
| confirmation->set_text(p_option == FILE_QUIT ? TTR("Exit the editor?") : TTR("Reload Current Project?")); | |||
There was a problem hiding this comment.
That's not correct when using RUN_PROJECT_MANAGER. There are three possible options which should all have their wn text.
|
Does it really fix this? Feel free to correct me please, but I find the commit "Made reload current project ask for confirmation with unsaved changes" 8d1827c to be the cause of it. It is done in good faith, but the confirmation dialog does appear on reload even if there's no unsaved changes at all. |
|
@Mickeon So do I remove the confirmation if all files are saved? |
|
I suppose so, yeah. As you've mentioned, this problem is not present in |
Use if else statement https://github.com/godotengine/godot/blob/3.x/editor/editor_node.cpp#L2718 |
|
If you are removing the confirmation then you have to remove interface/editor/quit_confirmation too, as now its of no use. Like in #32321 |
|
That seems to go a bit over the scope of the issue it was trying to solve. This is removing the quit confirmation for quitting the editor in all cases. |
|
So do I remove quit confirmation only when reloading project and files are saved? @akien-mga |
|
Yes, I think that would be the proper fix. You just need to check |
|
Thanks! |
fixes #60783