-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward+: TAA or FSR2 on a transparent viewport causes the viewport to turn opaque #69492
Comments
I can confirm this in case it's needed. Happened to me to just yesterday in beta17 win 10 with a subviewport. |
From a brief look into it it seems like the TAA resolve step intentionally ignores the alpha component as it resolves the color, tonemapping, history, etc. It seems taking alpha into account would also expand the memory used during execution. There is no obvious solution as to how to extend this in the shader as it'd need to use a separate path for mixing the alpha (to avoid tonemapping) and would probably need another variant of the shader to not cause a performance impact when transparent output isn't necessary (which is the more common use case). Adding a warning and disabling TAA for this use case might be the more reasonable approach here. |
Ideally I'd be using TAA, but this has a bug right now with viewports: godotengine/godot#69492
Also seems to happen with FSR 2 enabled. FSR 1 works properly |
FSR 1.0 with scale less than 1 also turns background to opaque. This is my system info: |
Godot version
4.0.beta7
System information
Fedora 36, Vulkan Forward Plus, AMD Radeon RX 6900 XT
Issue description
When enabling temporal antialiasing, the viewport becomes opaque if it's currently transparent.
This does not occur with FXAA and MSAA, both of which support transparent viewports (with some visible artifacts though).
If it's not possible to support TAA on transparent viewports, I suggest making the transparent viewport property take priority (so it disables TAA), and print a warning if both TAA and transparent viewport are enabled.
Steps to reproduce
Minimal reproduction project
test_taa_transparent_viewport.zip
The text was updated successfully, but these errors were encountered: