Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain VisualShader nodes (constants) contain a selectable, blank bar above the editor part #75598

Closed
Geometror opened this issue Apr 2, 2023 · 1 comment · Fixed by #88951

Comments

@Geometror
Copy link
Member

Geometror commented Apr 2, 2023

Godot version

4.1.dev (21d080e)

System information

-

Issue description

If you click on it once it stays selected until you reload the editor (or in some cases toggle the preview).

grafik

There seems to be a context menu registered for this, but the entries are disfunctional:

grafik
(I'd assume that clicking on "Copy Value" on a TransformConstant and then clicking on "Paste Value" on another TransformConstant or Transform property editor is its intended use case, but that does nothing - just like "Copy Property Path" (which does not even make sense to me here).

Edit:
This is probably because some VisualShader ***Constant nodes use the same property editors which are used in the inspector:

grafik
So the blank bar usually contains the property's name, but since this is no property here it remains empty. I think it should either be editable to give the constant a name or removed/replaced completely.

Steps to reproduce

Create a VisualShader resource and add e.g. a TransformConstant or Vector2/3/4Constant.

Minimal reproduction project

-

@jsjtxietian
Copy link
Contributor

jsjtxietian commented Oct 16, 2023

It seems Nodes like VisualShaderNodeVec3Parameter suffers this problem too if enable it's default value, they use the same property editors which are used in the inspector. And for this case, the blank bar should be removed since it's already has a name field.

image

However after some digging, I find that it's non trivial to remove this label :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants