Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make editing properties more intuitive in VisualShader #88951

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Make editing properties more intuitive in VisualShader #88951

merged 1 commit into from
Mar 5, 2024

Conversation

Geometror
Copy link
Member

This PR aims to make editing properties in VisualShader more intuitive.
Fixes #75598.
Fixes godotengine/godot-proposals#9183 (partly).

Detailed changes:

  • Focus the first focusable control when opening the property editor popup
  • Adjust the size of the property editor popup based on the type
  • Remove the blank area of the property editor when no label text is set

Before:

grafik

grafik

After:

grafik

grafik

@Geometror Geometror added this to the 4.3 milestone Feb 28, 2024
@Geometror Geometror requested a review from a team as a code owner February 28, 2024 11:10
@Geometror Geometror mentioned this pull request Feb 28, 2024
Closed
@fire fire requested a review from a team February 29, 2024 18:28
fire
fire approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the usability improvements but I haven't checked the code.

@akien-mga akien-mga requested review from KoBeWi and Calinou March 1, 2024 12:54
AThousandShips
AThousandShips approved these changes Mar 1, 2024
View reviewed changes
editor/plugins/visual_shader_editor_plugin.cpp Outdated Show resolved Hide resolved
editor/plugins/visual_shader_editor_plugin.cpp Outdated Show resolved Hide resolved
editor/plugins/visual_shader_editor_plugin.cpp Outdated Show resolved Hide resolved
editor/plugins/visual_shader_editor_plugin.cpp Outdated Show resolved Hide resolved
editor/plugins/visual_shader_editor_plugin.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit 6399fae into godotengine:master Mar 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@AThousandShips AThousandShips AThousandShips approved these changes

@KoBeWi KoBeWi KoBeWi approved these changes

@fire fire fire approved these changes

@Calinou Calinou Awaiting requested review from Calinou

Assignees
No one assigned
Labels
enhancement topic:editor topic:shaders usability
Projects
None yet
Milestone
4.3
5 participants
@Geometror @akien-mga @fire @KoBeWi @AThousandShips