Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export android AAB: Output dialog hidden automatically on error #76497

Closed
j3k0 opened this issue Apr 27, 2023 · 7 comments
Closed

Export android AAB: Output dialog hidden automatically on error #76497

j3k0 opened this issue Apr 27, 2023 · 7 comments

Comments

@j3k0
Copy link

j3k0 commented Apr 27, 2023

Godot version

4.0.2

System information

macOS, Apple M1, Ventura 13.1

Issue description

When running Export with Android (gradle) and it fails, the error output dialog gets closed immediately after the error occurs, making it impossible to debug what the issue is.

Weird things: sometimes, after that occurs, when saving the project, I can see that window appear for a few milliseconds, so it still exists and it should be possible to make appear.


Possible workarounds:

  • a way to show again dialogs that have been hidden (in the code, the dialog isn't deleted, it's just hidden)
  • saving build outputs to log files

Steps to reproduce

Trying to export any godot project's AAB for android on a macOS computer with anything that makes gradle fail.

Minimal reproduction project

N/A : empty project

@j3k0
Copy link
Author

j3k0 commented Apr 27, 2023

This mitigates the issue for me (allowing to see logs in the standard output window), it's not a proper fix though.

diff --git a/editor/editor_node.cpp b/editor/editor_node.cpp
index 87ca642be5..98cdc86aeb 100644
--- a/editor/editor_node.cpp
+++ b/editor/editor_node.cpp
@@ -6670,6 +6670,7 @@ int EditorNode::execute_and_show_output(const String &p_title, const String &p_p
                                String to_add = eta.output.substr(prev_len, eta.output.length());
                                prev_len = eta.output.length();
                                execute_outputs->add_text(to_add);
+                               this->log->add_message(to_add, EditorLog::MSG_TYPE_STD);
                                DisplayServer::get_singleton()->process_events(); // Get rid of pending events.
                                Main::iteration();
                        }

@finepointcgi
Copy link

Confirmed issue with Windows 11 as well. If you run Godot in console mode it does not log any issues to the console as well.

@vladimir-sama
Copy link

vladimir-sama commented Jun 10, 2023

Same on Windows 10 (Atlas OS) and Godot 4.0.3 AAB build, workarounds or fixes?

@FeralBytes
Copy link
Contributor

Same on Linux mint. for Godot 4.1.1.

@alfredomaussa
Copy link

I'm actually experiencing the same issue at the same time as this one: #80491

I had to use OBS to record the screen and look at each frame to know what is the error saying.

@jpmcgrath
Copy link

jpmcgrath commented Oct 23, 2023

I don't know if it is helpful to add a +1, but I have been struggling with this as well. Very frustrating to try and determine what is the cause of Export for Android when I have to record a screen recording to try and see the logs flash by. The suggestion to store these logs to a file would work well for my needs, or just not closing the window.

On Macos, Godot v4.1.1.

@m4gr3d
Copy link
Contributor

m4gr3d commented Nov 27, 2023

Fixed by #84779

@m4gr3d m4gr3d closed this as completed Nov 27, 2023
@akien-mga akien-mga added this to the 4.2 milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants