Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve the output from the gradle build command #84779

Merged

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Nov 12, 2023

Updates EditorNode#execute_and_show_output(...) to return the output of the executed command so it can be displayed to the user either when the command fails or when verbose settings are enabled.

Fixes #80873

Screenshot 2023-11-11 at 5 02 49 PM

@m4gr3d m4gr3d added bug platform:android topic:export cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Nov 12, 2023
@m4gr3d m4gr3d added this to the 4.2 milestone Nov 12, 2023
@m4gr3d m4gr3d requested a review from a team as a code owner November 12, 2023 01:23
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good to merge once the TTR calls are fixed up.

Edit: Fixed them up myself to merge this now in preparation for beta 6.

Updates `EditorNode#execute_and_show_output(...)` to return the output of the executed command.
@akien-mga akien-mga force-pushed the keep_android_build_window_open_on_failure branch from d9ee6c6 to 136b7f9 Compare November 12, 2023 11:07
@akien-mga akien-mga merged commit 87ba798 into godotengine:master Nov 12, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the keep_android_build_window_open_on_failure branch November 13, 2023 14:39
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android build issue - access to logs
4 participants