-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve the output from the gradle build command #84779
Merged
akien-mga
merged 1 commit into
godotengine:master
from
m4gr3d:keep_android_build_window_open_on_failure
Nov 12, 2023
Merged
Preserve the output from the gradle build command #84779
akien-mga
merged 1 commit into
godotengine:master
from
m4gr3d:keep_android_build_window_open_on_failure
Nov 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
added
bug
platform:android
topic:export
cherrypick:4.1
Considered for cherry-picking into a future 4.1.x release
labels
Nov 12, 2023
akien-mga
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, good to merge once the TTR
calls are fixed up.
Edit: Fixed them up myself to merge this now in preparation for beta 6.
Updates `EditorNode#execute_and_show_output(...)` to return the output of the executed command.
akien-mga
force-pushed
the
keep_android_build_window_open_on_failure
branch
from
November 12, 2023 11:07
d9ee6c6
to
136b7f9
Compare
Thanks! |
This was referenced Nov 14, 2023
YuriSizov
removed
the
cherrypick:4.1
Considered for cherry-picking into a future 4.1.x release
label
Jan 23, 2024
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
EditorNode#execute_and_show_output(...)
to return the output of the executed command so it can be displayed to the user either when the command fails or whenverbose
settings are enabled.Fixes #80873