Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Gradle's standard output/error to the console when exporting … #47695

Closed
wants to merge 3 commits into from

Conversation

myood
Copy link

@myood myood commented Apr 7, 2021

Implementation proposal for godotengine/godot-proposals#2559 (Sorry maintainers - I don't know how to properly link this PR to the proposal)

if verbose is set, then print command invoked during export

Bugsquad edit: This closes godotengine/godot-proposals#2559.

@myood myood requested a review from a team as a code owner April 7, 2021 10:03
@myood
Copy link
Author

myood commented Apr 7, 2021

@Calinou Oops! I accidentaly created zombie, duplicated "Server Builds" action. Sorry! :-( Hope that can be undone (I already reverted the change from my fork that caused that). I leave it as is to avoid more damage, sigh
image

@Calinou
Copy link
Member

Calinou commented Apr 7, 2021

Oops! I accidentaly created zombie, duplicated "Server Builds" action. Sorry! :-( Hope that can be undone (I already reverted the change from my fork that caused that). I leave it as is to avoid more damage, sigh

As far as I know, GitHub Actions will leave it there permanently, so there's nothing that can be done about it. No worries 🙂

@Calinou Calinou added enhancement topic:editor topic:porting platform:android cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Apr 7, 2021
@Calinou Calinou added this to the 4.0 milestone Apr 7, 2021
@Calinou
Copy link
Member

Calinou commented Jun 3, 2022

I was thinking about this again and it's probably a good idea to always print these messages on export. This would mean using print_line() instead of print_verbose().

After making this change, please squash commits together into a single commit so we can merge this.

@YuriSizov YuriSizov requested a review from a team February 10, 2023 14:27
@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 10, 2023
@YuriSizov YuriSizov modified the milestones: 4.1, 4.2 Jun 14, 2023
@AThousandShips AThousandShips modified the milestones: 4.2, 4.3 Oct 26, 2023
@m4gr3d
Copy link
Contributor

m4gr3d commented Feb 25, 2024

The functionality is already provided by #84779.

@m4gr3d m4gr3d closed this Feb 25, 2024
@AThousandShips AThousandShips added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Feb 25, 2024
@AThousandShips AThousandShips removed this from the 4.3 milestone Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Gradle's standard output/error to the console when exporting to Android
5 participants