Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Tree scrollbar gets wonky when some of the nodes are multiline #77853

Open
MewPurPur opened this issue Jun 4, 2023 · 7 comments
Open

Comments

@MewPurPur
Copy link
Contributor

MewPurPur commented Jun 4, 2023

Godot version

Godot v4.1.dev4

System information

Ubuntu 22.04.2 LTS 22.04 - Vulkan (Forward+) - integrated Intel(R) HD Graphics 4400 (HSW GT2) () - Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz (4 Threads)

Issue description

To be more precise, you can't scroll all the way to the bottom; if you do, the view goes back up shortly. Here's an example (I'm sorry for the wonky cropping, but should demonstrate it well-enough):

Wonky.mp4

Nodes are probably not supposed to be multiline, but this issue likely goes deeper.

Steps to reproduce

Shown above pretty much

Minimal reproduction project

N/A

@capnm
Copy link
Contributor

capnm commented Jun 5, 2023

@MewPurPur my private calming down innovation XY workaround in this case :P

--- a/scene/gui/tree.cpp
+++ b/scene/gui/tree.cpp
@@ -1948,7 +1948,7 @@ void Tree::update_item_cell(TreeItem *p_item, int p_col) {
                font_size = theme_cache.font_size;
        }
        p_item->cells.write[p_col].text_buf->add_string(valtext, font, font_size, p_item->cells[p_col].language);
-       p_item->cells.write[p_col].text_buf->set_break_flags(TextServer::BREAK_MANDATORY | TextServer::BREAK_WORD_BOUND | TextServer::BREAK_ADAPTIVE);
+       p_item->cells.write[p_col].text_buf->set_break_flags(TextServer::BREAK_NONE);
        TS->shaped_text_set_bidi_override(p_item->cells[p_col].text_buf->get_rid(), structured_text_parser(p_item->cells[p_col].st_parser, p_item->cells[p_col].st_args, valtext));
        p_item->cells.write[p_col].dirty = false;
 }

@dalexeev
Copy link
Member

dalexeev commented Jun 5, 2023

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Jun 5, 2023

To my understanding, while this configurability will allow us to fix the remote tree, scrollbars will still be bugged for multiline trees?

I'll test the PR though

@MewPurPur
Copy link
Contributor Author

I'll try not to forget to try to create a MRP since this has been addressed in the editor.

@capnm
Copy link
Contributor

capnm commented Jun 24, 2023

24e7502 The text gets still inside the icons:
image
image

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Jun 24, 2023

This is an older issue, I don't know if it's reported. It's also unrelated to multiline items.

@capnm
Copy link
Contributor

capnm commented Jun 24, 2023

I believe it was also introduced by the multi-line tree PR or subsequent repair attempts.
4.0.3.slable:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants