Crash on exit iOS application when using iOS 13 #7966

sanja-sa · 2017-03-06T08:45:30Z

iPhone 5( 32bit) - Godot version: 2.1.2

Crash on exit application in godot/servers/audio/audio_server_sw.cpp on line 774:

void AudioServerSW::_thread_func(void *self) {

	Thread::set_name("AudioServerSW");

	AudioServerSW *as=(AudioServerSW *)self;

	while (!as->exit_update_thread) {
		as->_update_streams(true);
		OS::get_singleton()->delay_usec(5000); <<--  Crash here
	}

}

Resume: OS::get_singleton() -- not thread save (maybe do "delay_usec" as static) and not correct finalize class.
In my case OS::get_singleton() === NULL.

The text was updated successfully, but these errors were encountered:

lukaskotik · 2017-03-06T22:48:07Z

It seems to me that this can be the same issue as (see the last comment) #5426

sanja-sa · 2017-03-14T07:34:00Z

It looks like the crash occurs in different places when exit the application. It looks like a memory leak somewhere. Only iOS version. It takes more time to search for a leak.

kubecz3k · 2018-04-10T17:15:59Z

First of all thank you for your report and sorry for the delay.

We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.

We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about its current status here?

For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.

Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.

Thanks in advance.

Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

sanja-sa · 2018-04-10T17:48:38Z

I cannot test it in Godot 3.0 version, because in this case i must rewrite all project code for Godot 3.0, but it's cannot be done in this time point. Godot 3.0 is slower than 2.1.4 and I'm waiting 3.1 with Vulcan version. Android version (Adreno GPU) very slowely and crossplatform developing in this case breaked.

kubecz3k · 2018-04-10T17:55:19Z

Oh ok I see. Will need to test in 3.1 in such case

aaronfranke · 2018-07-09T18:32:42Z

Godot 3.1 will not have Vulkan support, you will have to wait for 4.0 for that.

You should update your project for Godot 3.x to confirm if the issue still exists. If Godot is slower for you then that's another issue that should be addressed. But if you are not willing to test it in the latest releases I'm not sure how much we can help you.

On a related note, do we want to keep supporting 32-bit iPhones? Apple killed off 32-bit iPhone apps this year with the release of iOS 11. Even if we drop support for 32-bit iPhone apps in master, 2.1 and 3.0 would still support it.

Xancett · 2019-08-13T12:26:38Z

I have this issue in 3.1.1. I've only recently gotten the error message after adding low processor mode. I can look into this further but it might stem from there.

Xancett · 2019-08-15T11:55:51Z

Did some tests and I discovered it was not due to the low processor mode but due to the ios13 beta. When not on a beta firmware for iOS I'm not having any crashes on exit.

pixelcarrot · 2019-09-19T18:11:54Z

I just upgraded to official iOS 13. It crashed when killing the app.

Xancett · 2019-09-19T23:24:41Z

2.1.2 only or 3.1.1 as well?

pixelcarrot · 2019-09-20T01:51:57Z

Godot 3.1.1

Previously, I tested on my iPad (with iOS 13 beta). It crashed when killing the app but it works fine on my iPhone iOS 12. After upgrading my iPhone to official iOS 13, I receive the same crash. :)

Noticed that when I just open the app, at the home screen, killing it has no crash. But when I open the app then change to another screen. Then it crashed when I kill the app.

Xancett · 2019-09-20T11:58:01Z

According to the verge (https://www.theverge.com/2019/9/19/20874293/apple-ios-13-1-ipados-september-24th-early-release-date-update-bug-fixes-features) ios 13.1 will be out on the 24th. This bug doesn't exist on the 13.1 beta that I'm currently in but did in a previous 13 beta. Maybe the issue will be patched in 13.1?

"More importantly, Apple promises that 13.1 will bring general bug fixes to iOS 13, which the current software could definitely benefit from. (Our review of the current 13.0 software notes a litany of issues we encountered while testing the new update.)"

johngirvin · 2019-10-03T13:10:18Z

Godot 3.1.1

Confirmed crashes on iOS 13.0 simulator and 13.1 iPhone XR when switching the game to the background (press device Home button). GLES2/GLES3 driver same. Crash logs attached.

Cannot reproduce on previous iOS versions.

gles2.txt
gles3.txt

pixelcarrot · 2019-10-03T13:22:09Z

Follow #32194 remove [self drawView] in layoutSubviews and re-compile can fix crashes when switching to the background (press Home button), but it still crashes when closing in the app switcher.

ealataur · 2019-10-18T11:00:39Z

Hi all. I removed duplicated drawView and moving this part of code
from

- (void)drawView {
	if (useCADisplayLink) {
		// Pause the CADisplayLink to avoid recursion
		[displayLink setPaused:YES];

		// Process all input events
		while (CFRunLoopRunInMode(kCFRunLoopDefaultMode, 0.01, TRUE) == kCFRunLoopRunHandledSource)
			;

		// We are good to go, resume the CADisplayLink
		[displayLink setPaused:NO];
	}

	if (!active) {
		printf("draw view not active!\n");
		return;
	};

to

- (void)drawView {

	if (!active) {
		printf("draw view not active!\n");
		return;
	};

	if (useCADisplayLink) {
		// Pause the CADisplayLink to avoid recursion
		[displayLink setPaused:YES];

		// Process all input events
		while (CFRunLoopRunInMode(kCFRunLoopDefaultMode, 0.01, TRUE) == kCFRunLoopRunHandledSource)
			;

		// We are good to go, resume the CADisplayLink
		[displayLink setPaused:NO];
	}

And crashes is gone. Tested many time and not catched yet.

volzhs · 2019-10-18T15:22:03Z

@ealataur would you make a PR? 😄

gerald1248 · 2019-10-28T11:27:43Z

@ealataur could you post your diff? It's @justinngdev's patch plus the change you describe here?

Not fixed in the published 3.2 alpha 3 export template.

ealataur · 2019-10-28T12:01:46Z

@gerald1248
This patch for 3.1.1 stable [66baa3b]
But I think it usable for master too..

patch.diff.zip

gerald1248 · 2019-10-28T13:15:35Z

@ealataur awesome, thanks!

gerald1248 · 2019-10-29T03:10:09Z

@ealataur can confirm your patch fixes the issue. Uploading to App Store Connect now. Thanks again! (BTW I could swear I see dropped frames where previously I didn't. Am I missing optimisation flags I should pass to scons when compiling? I simply used scons p=iphone tools=no target=release arch=amd64 and the matching 32-bit variant before creating the universal library.)

akien-mga · 2019-10-29T06:56:36Z

A pull request would be welcome so that we can review and hopefully merge the fix.

ealataur · 2019-10-29T08:04:19Z

I created a pull request
#33154

gerald1248 · 2019-10-30T07:51:42Z

@ealataur I have rebuilt using optimize=speed but I still observe a serious performance degradation. Happy to believe that I'm not building for iOS correctly, but do you think it's worth checking if the modified CFRunLoopRunInMode call has an impact on frame rate?

ealataur · 2019-10-30T09:20:31Z

@gerald1248
please try change back this
while (CFRunLoopRunInMode(kCFRunLoopDefaultMode, 0.01, TRUE) == kCFRunLoopRunHandledSource)
to this
while (CFRunLoopRunInMode(kCFRunLoopDefaultMode, 0.0, TRUE) == kCFRunLoopRunHandledSource)

gerald1248 · 2019-10-31T12:15:12Z

I don't have measurements, but switching back seems to have brought performance back to a normal level.

…

On Wed, 30 Oct 2019, 09:21 Max Pestov, ***@***.***> wrote: @gerald1248 <https://github.com/gerald1248> please try change back this while (CFRunLoopRunInMode(kCFRunLoopDefaultMode, 0.01, TRUE) == kCFRunLoopRunHandledSource) to this while (CFRunLoopRunInMode(kCFRunLoopDefaultMode, 0.0, TRUE) == kCFRunLoopRunHandledSource) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7966?email_source=notifications&email_token=AAFWFQBYJDXXNYKZTBVLM73QRFGZLA5CNFSM4DCPOT32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECTON6Q#issuecomment-547809018>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFWFQCE5XFYLT2GYVLG6JTQRFGZLANCNFSM4DCPOT3Q> .

ealataur · 2019-10-31T12:20:47Z

@gerald1248
Ok. I will make a commit and pull request

Fixes godotengine#7966.

Fixes godotengine#7966. (cherry picked from commit 29bde8c)

Fixes #7966. (cherry picked from commit 29bde8c)

jeudy-ua · 2019-12-30T05:22:36Z

@gerald1248
Ok. I will make a commit and pull request

I have this problem with my game. Is this fix on version 3.2 stable? or do I have to recompile from the latest master? (I actually tried, but the export templates I got gave me errors when exporting).

@ealataur can you please share which export templates you used after you recompiled godot with the fix?

gerald1248 · 2019-12-30T11:08:35Z

Use one of the later betas: I'm using 3.2b3 and it works fine. Avoid 3.2b1-2 as performance was much worse then. The betas are useful as they come with precompiled templates.

…

On Mon, 30 Dec 2019, 05:22 jeudy-ua, ***@***.***> wrote: @gerald1248 <https://github.com/gerald1248> Ok. I will make a commit and pull request I have this problem with my game. Is this fix on version 3.2 stable? or do I have to recompile from the latest master? (I actually tried, but the export templates I got gave me errors when exporting). @ealataur <https://github.com/ealataur> can you please share which export templates you used after you recompiled godot with the fix? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7966?email_source=notifications&email_token=AAFWFQGABAG3YVEOHAOIJSDQ3GAR3A5CNFSM4DCPOT32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZTMFQ#issuecomment-569587222>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFWFQCLZGDHZIW3QVLHBC3Q3GAR3ANCNFSM4DCPOT3Q> .

Fixes #7966. (cherry picked from commit 29bde8c)

Fixes godotengine#7966. (cherry picked from commit 29bde8c)

bojidar-bg added bug discussion topic:core platform:ios labels Mar 6, 2017

Calinou added the confirmed label Sep 19, 2019

Calinou changed the title ~~Crash on exit iOS application~~ Crash on exit iOS application when using iOS 13 Sep 19, 2019

akien-mga added this to the 3.2 milestone Oct 28, 2019

ealataur mentioned this issue Oct 29, 2019

fix crash on iOS 13 #33154

Merged

akien-mga pushed a commit to ealataur/godot that referenced this issue Nov 5, 2019

Fix crash on exit or resume on iOS 13

29bde8c

Fixes godotengine#7966.

akien-mga closed this as completed in #33154 Nov 5, 2019

akien-mga pushed a commit to akien-mga/godot that referenced this issue Nov 8, 2019

Fix crash on exit or resume on iOS 13

ee4d1e4

Fixes godotengine#7966. (cherry picked from commit 29bde8c)

akien-mga pushed a commit that referenced this issue Nov 8, 2019

Fix crash on exit or resume on iOS 13

82e52c3

Fixes #7966. (cherry picked from commit 29bde8c)

dylantmarsh mentioned this issue Jan 9, 2020

iOS 13.1+ Crash on Application Exit #34952

Closed

akien-mga pushed a commit that referenced this issue May 28, 2020

Fix crash on exit or resume on iOS 13

18484dd

Fixes #7966. (cherry picked from commit 29bde8c)

akien-mga mentioned this issue Jun 13, 2020

App terminate on iOS 11 when enter to background #11623

Closed

halotroop2288 pushed a commit to Homebrodot/Godot that referenced this issue Jan 12, 2024

Fix crash on exit or resume on iOS 13

366babc

Fixes godotengine#7966. (cherry picked from commit 29bde8c)

bherdm pushed a commit to bherdm/godot-for-ouya that referenced this issue Jul 18, 2024

Fix crash on exit or resume on iOS 13

36ced74

Fixes godotengine#7966. (cherry picked from commit 29bde8c)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crash on exit iOS application when using iOS 13 #7966

Crash on exit iOS application when using iOS 13 #7966

sanja-sa commented Mar 6, 2017

lukaskotik commented Mar 6, 2017

sanja-sa commented Mar 14, 2017

kubecz3k commented Apr 10, 2018

sanja-sa commented Apr 10, 2018

kubecz3k commented Apr 10, 2018

aaronfranke commented Jul 9, 2018 •

edited

Loading

Xancett commented Aug 13, 2019 •

edited

Loading

Xancett commented Aug 15, 2019

pixelcarrot commented Sep 19, 2019

Xancett commented Sep 19, 2019

pixelcarrot commented Sep 20, 2019

Xancett commented Sep 20, 2019

johngirvin commented Oct 3, 2019

pixelcarrot commented Oct 3, 2019

ealataur commented Oct 18, 2019

volzhs commented Oct 18, 2019

gerald1248 commented Oct 28, 2019 •

edited

Loading

ealataur commented Oct 28, 2019 •

edited

Loading

gerald1248 commented Oct 28, 2019

gerald1248 commented Oct 29, 2019 •

edited

Loading

akien-mga commented Oct 29, 2019

ealataur commented Oct 29, 2019

gerald1248 commented Oct 30, 2019

ealataur commented Oct 30, 2019

gerald1248 commented Oct 31, 2019 via email

ealataur commented Oct 31, 2019

jeudy-ua commented Dec 30, 2019

gerald1248 commented Dec 30, 2019 via email

Crash on exit iOS application when using iOS 13 #7966

Crash on exit iOS application when using iOS 13 #7966

Comments

sanja-sa commented Mar 6, 2017

lukaskotik commented Mar 6, 2017

sanja-sa commented Mar 14, 2017

kubecz3k commented Apr 10, 2018

sanja-sa commented Apr 10, 2018

kubecz3k commented Apr 10, 2018

aaronfranke commented Jul 9, 2018 • edited Loading

Xancett commented Aug 13, 2019 • edited Loading

Xancett commented Aug 15, 2019

pixelcarrot commented Sep 19, 2019

Xancett commented Sep 19, 2019

pixelcarrot commented Sep 20, 2019

Xancett commented Sep 20, 2019

johngirvin commented Oct 3, 2019

pixelcarrot commented Oct 3, 2019

ealataur commented Oct 18, 2019

volzhs commented Oct 18, 2019

gerald1248 commented Oct 28, 2019 • edited Loading

ealataur commented Oct 28, 2019 • edited Loading

gerald1248 commented Oct 28, 2019

gerald1248 commented Oct 29, 2019 • edited Loading

akien-mga commented Oct 29, 2019

ealataur commented Oct 29, 2019

gerald1248 commented Oct 30, 2019

ealataur commented Oct 30, 2019

gerald1248 commented Oct 31, 2019 via email

ealataur commented Oct 31, 2019

jeudy-ua commented Dec 30, 2019

gerald1248 commented Dec 30, 2019 via email

aaronfranke commented Jul 9, 2018 •

edited

Loading

Xancett commented Aug 13, 2019 •

edited

Loading

gerald1248 commented Oct 28, 2019 •

edited

Loading

ealataur commented Oct 28, 2019 •

edited

Loading

gerald1248 commented Oct 29, 2019 •

edited

Loading