Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accumulation of VSeparator in toolbox when selecting a node #82094

Closed
JekSun97 opened this issue Sep 22, 2023 · 2 comments · Fixed by #82131
Closed

Accumulation of VSeparator in toolbox when selecting a node #82094

JekSun97 opened this issue Sep 22, 2023 · 2 comments · Fixed by #82131

Comments

@JekSun97
Copy link
Contributor

Godot version

4.2.dev5

System information

Windows 10

Issue description

In an open scene of a glb file, when selecting different nodes, seperators endlessly accumulate in the top field, then the editor slows down a lot.

err

Steps to reproduce

Open the main scene and perform the above actions

Minimal reproduction project

test.zip

@JekSun97
Copy link
Contributor Author

vsep

@jsjtxietian
Copy link
Contributor

jsjtxietian commented Sep 22, 2023

I guess this bug has something to do with the error log in the editor:

image

It seems the code failed to remove the control from menu panel. I will try to fix this bug : )

void Node3DEditor::remove_control_from_menu_panel(Control *p_control) {
	ERR_FAIL_NULL(p_control);
	ERR_FAIL_COND(p_control->get_parent() != context_toolbar_hbox);

	p_control->disconnect("visibility_changed", callable_mp(this, &Node3DEditor::_update_context_toolbar));

	context_toolbar_hbox->remove_child(context_toolbar_separators[p_control]);
	context_toolbar_hbox->remove_child(p_control);
	context_toolbar_separators.erase(p_control);

	_update_context_toolbar();
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants