Fix skeleton 3d editor's toolbar ui deleted from wrong container #82131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
reviewed
Sep 23, 2023
jsjtxietian
force-pushed
the
fix-skeleton-editor-deleted-in-wrong-container
branch
from
7734d19 to
a2a3c63
Compare
timothyqiu
approved these changes
Sep 23, 2023
|
Thank you for quick bug fix :) |
YuriSizov
reviewed
Sep 23, 2023
jsjtxietian
force-pushed
the
fix-skeleton-editor-deleted-in-wrong-container
branch
from
a2a3c63 to
2679118
Compare
|
Thanks! |
jsjtxietian
deleted the
fix-skeleton-editor-deleted-in-wrong-container
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82094
The bug comes from node mismatch: In
create_editors, editors likeanimation_hbare added totopmenu_barbut in the destructor they are removed fromNode3DEditor::get_singleton()which is the parent oftopmenu_bar.