Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md link to editor translations readme is broken #82495

Closed
CEMartinezp opened this issue Sep 28, 2023 · 1 comment · Fixed by #83095
Closed

CONTRIBUTING.md link to editor translations readme is broken #82495

CEMartinezp opened this issue Sep 28, 2023 · 1 comment · Fixed by #83095

Comments

@CEMartinezp
Copy link

CEMartinezp commented Sep 28, 2023

Godot version

4.1.1-stable

System information

Windows 11

Issue description

When clicking "translation readme" in the "CONTRIBUTING.md" file:
image

It shows:
Screenshot 2023-09-28 151721

This means important information for new translators wanting to contribute is missing.

I believe, this issue is cause by not having the proper link attached. The current link seems to taken from an old file that is no longer present in the current version of the project (editor/translations/README.md).

I think the intended link is:
https://docs.godotengine.org/en/latest/contributing/documentation/editor_and_docs_localization.html
My reasoning is because the information in this link seems to be intended to be read by new translators but can only be found by diving deeper into other links, making the instructions confusing.

Perhaps, a possible solution would be to simply change the link to the one I provided in the CONTRIBUTING.md file, or just removing it entirely until a new README file is created.

Steps to reproduce

In the "CONTRIBUTING.md" file go to the headline that says "Contributing to Godot's translation" and click on "translation readme"

Minimal reproduction project

N/A

@MatheusPese
Copy link

MatheusPese commented Sep 29, 2023

The actual intended link is a readme.md file that is present on all versions of godot but 4.0 and 4.1.

Should be an easy fix if there is not any change in the way godot handles translations from 3.x to 4.x.

EDIT:

Actually, no, after digging through some commits i found that it should link to https://github.com/godotengine/godot-editor-l10n

shubhalgupta added a commit to shubhalgupta/godot that referenced this issue Oct 9, 2023
realdezzy added a commit to realdezzy/godot that referenced this issue Oct 9, 2023
I added a link to the README in version 3.5 because it seems clear and to the point.
Although I think adding a README to the newer versions would be better
@akien-mga akien-mga changed the title CONTRIBUTING.md is Broken CONTRIBUTING.md link to editor translations readme is broken Oct 10, 2023
@akien-mga akien-mga added this to the 4.2 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants