Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Web export templates for 3.5.3 on Windows fails parsing emcc version #82585

Closed
AnnA-Ayms opened this issue Sep 30, 2023 · 3 comments
Closed

Comments

@AnnA-Ayms
Copy link

AnnA-Ayms commented Sep 30, 2023

Godot version

3.5.3

System information

Windows 10

Issue description

Can't build a web template (at least under Windows 10) with the current 3.5.3 build as is (necessary if Compiling project with PCK encryption key).
relates to changes after #81340

Commenting out line 189 "cc_semver = tuple(get_compiler_version(env))" of \godot-3.5\platform\javascript "detect.py"
and I was able to compile the template since neither
"if env["use_thinlto"] or env["use_lto"]:" nor "if env["gdnative_enabled"]:"
apply to my use but investigation by someone more competent on these matters than me would be good.

results before the comment out
Z:\godot-3.5>scons platform=javascript tools=no target=release
scons: Reading SConscript files ...
Auto-detected 4 CPU cores available for build parallelism. Using 4 cores by default. You can override it with the -j argument.
Couldn't parse CXX environment variable to infer compiler version.
TypeError: 'NoneType' object is not iterable:
File "Z:\godot-3.5\SConstruct", line 449:
detect.configure(env)
File "Z:\godot-3.5./platform/javascript\detect.py", line 189:
cc_semver = tuple(get_compiler_version(env))

Steps to reproduce

Just trying to build a Web Export Templates for version 3.5.3 under Windows 10 caused it.
"scons platform=javascript tools=no target=release"

Minimal reproduction project

N/A

@AnnA-Ayms AnnA-Ayms changed the title Building export templates under Compiling for the Web Building export templates for 3.5.3 under Compiling for the Web Sep 30, 2023
@Sauermann Sauermann added this to the 3.x milestone Oct 8, 2023
@eggnot
Copy link

eggnot commented Oct 8, 2023

Same error for me.
Win10, Visual Studio 2022, emsdk 3.1.46

@yikescloud
Copy link

yikescloud commented Oct 16, 2023

Same issue here, Vscode 2022, emsdk 3.1.14
Seems like get_compiler_version(env) return a none type not the emsdk version tuple
I change the code to cc_semver = (3,1,14) and it fixed

@akien-mga akien-mga changed the title Building export templates for 3.5.3 under Compiling for the Web Building Web export templates for 3.5.3 on Windows fails parsing emcc version Oct 16, 2023
@akien-mga akien-mga self-assigned this Oct 16, 2023
akien-mga added a commit to akien-mga/godot that referenced this issue Jan 30, 2024
Quick fix for godotengine#82585.

A better fix requires refactoring the way we detect the compiler version
to make it more reliable, and get a consistent output. But I prefer to
keep changes minimal for 3.x branches at this point.

Also set CI version to 3.1.39, which is what we use for official 3.6 builds
since 3.6-beta4.
@akien-mga akien-mga modified the milestones: 3.x, 3.6 Jan 30, 2024
@akien-mga
Copy link
Member

Fixed by #87739.

akien-mga added a commit to akien-mga/godot that referenced this issue Jan 30, 2024
Quick fix for godotengine#82585.

A better fix requires refactoring the way we detect the compiler version
to make it more reliable, and get a consistent output. But I prefer to
keep changes minimal for 3.x branches at this point.

(cherry picked from commit 4206975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants