Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip from Editor Description field should propagate immediately #82896

Closed
ievr opened this issue Oct 6, 2023 · 3 comments · Fixed by #82916
Closed

Tooltip from Editor Description field should propagate immediately #82896

ievr opened this issue Oct 6, 2023 · 3 comments · Fixed by #82916

Comments

@ievr
Copy link

ievr commented Oct 6, 2023

Godot version

4.1.2rc1

System information

Windows 10

Issue description

When the user updates the Editor Description field, the update does not reflect as a tooltip until the node is deselected.

image

While this might seem irrelevant, it impacts the discoverability of the feature.
My immediate assumption was that the field was to be displayed in a tooltip, but upon testing it didn't work until I changed scenes. This might make new users dismiss the feature.

Steps to reproduce

  1. Open any project and click on a node
  2. Find the Editor Description field in inspector and type something into it
  3. Hover the node in the tree hierarchy with your mouse. Observe that it lacks a description
  4. Deselect and select the node again to see the updated description in the tooltip

Minimal reproduction project

N/A

@Mickeon
Copy link
Contributor

Mickeon commented Oct 6, 2023

While I do agree, to achieve the update in real time would probably require updating the entire tree all over again, if not handled the most ideal away.

@jsjtxietian
Copy link
Contributor

jsjtxietian commented Oct 6, 2023

The tooltip is built per _add_nodes instead of everytime editor description field changes. There is a commit message 9f026d5 mentioned this behaviour. cc @Calinou

I think I might have an idea how to fix this.

@Calinou
Copy link
Member

Calinou commented Oct 6, 2023

This was partially fixed by #66266, but you need to select another node for the tooltip to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants