-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support updating tooltip immediately after editor description change #82916
Support updating tooltip immediately after editor description change #82916
Conversation
You've linked the wrong issue it looks like |
2bd7c9a
to
c24dd27
Compare
Thanks! The github's auto complete for issue number is terrible. |
f9d6d3f
to
d035392
Compare
Instead of adding a new signal, you could reuse |
I'm a little worried about this as I prefer to not affect performance by this small commit. IMHO a little more code is fine compared to potential performance stalls, if we believe more and more people will use godot to make games with complex scenes. And it's not a configuration warning, so I think a seperate signal is fine. Feel free to correct me. |
You should add some delay for updating the tooltip, otherwise it's changed with every written character. |
IMHO the best way is to update the tooltip when the user left the input box (when it loses focus). Also how do we do this, use a timer, and when user input something new but the timer is not triggered, we reset the timer? |
d035392
to
269681c
Compare
Yes, the timer should be restarted with each input. |
b938b00
to
2d1d92d
Compare
The timer should be in SceneTreeEditor, not Node. |
Yes node is the wrong place (especiall when we dont have a editor macro) , but I wonder whether we should use a timer, seems a bit excessive |
2d1d92d
to
ac7e452
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks alright overall, but I'd look into changing Timer to SceneTreeTimer. Though technically the PR works correctly and this can be done later.
ac7e452
to
4680ced
Compare
Thanks! |
Should fix #82896
cc @Calinou