Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiler "Display internal functions" checkbox disappears #86394

Closed
prvak opened this issue Dec 21, 2023 · 5 comments · Fixed by #86398
Closed

Profiler "Display internal functions" checkbox disappears #86394

prvak opened this issue Dec 21, 2023 · 5 comments · Fixed by #86398

Comments

@prvak
Copy link

prvak commented Dec 21, 2023

Tested versions

4.3.dev [9d1cbab]

System information

Godot v4.3.dev (9d1cbab) - Linux Mint 21.2 (Victoria) - X11 - GLES3 (Compatibility) - Mesa Intel(R) HD Graphics 4600 (HSW GT2) () - Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz (8 Threads)

Issue description

I was hoping to check this cool new feature that allows profiling internal functions: #75623
However, the checkbox that enables the feature disappears after running the project.

This is how it looks like after starting the editor:
Screenshot from 2023-12-21 15-06-16

This is how it looks like after starting the game:
Screenshot from 2023-12-21 15-06-59

@reach-satori I am not sure what is the purpose of the following line but when I remove it, the checkbox does not disappear:

display_internal_profiles->set_visible(EDITOR_GET("debugger/profile_native_calls"));

Steps to reproduce

  1. Open any project, go to the Debugger -> Profile tab and notice that "Display internal functions" checkbox is there.
  2. Run the project, go to the Debugger -> Profile tab and notice that "Display internal functions" checkbox is gone.

Minimal reproduction project (MRP)

Does not depend on any specific project.

@reach-satori
Copy link
Contributor

Did you turn it on in the settings? Under the 'debugger' category. It's disabled by default.
Not sure why it shows up at first, though.

@prvak
Copy link
Author

prvak commented Dec 21, 2023

When I create a new project, the checkbox is initially visible. I was looking for "debugger/profile_native_calls" in the settings everywhere and I cannot find it. I do not have "Debuger" category, only "Debug" category. Where should I look for it?

Screenshot from 2023-12-21 16-35-47

@reach-satori
Copy link
Contributor

You're looking at the project settings. It's under Editor (in the menu bar) -> Editor settings -> debugger.

@YuriSizov
Copy link
Contributor

If this checkbutton is visible initially even when the setting is disabled, it's a bug (so the other way around from what you expect).

@prvak
Copy link
Author

prvak commented Dec 21, 2023

OMG! I totally forgot that there are both Project settings and Editor settings 🤦

So yes, it is the other way around. The checkbox is initially visible even when the Profile Native Calls is disabled in Editor settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants