Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal profiling button being visible when disabled in settings #86398

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix internal profiling button being visible when disabled in settings #86398

merged 1 commit into from
Mar 1, 2024

Conversation

reach-satori
Copy link
Contributor

@reach-satori reach-satori commented Dec 21, 2023 •
edited by AThousandShips
Loading

@reach-satori reach-satori requested a review from a team as a code owner December 21, 2023 16:37
@AThousandShips AThousandShips added this to the 4.3 milestone Dec 21, 2023
prvak
prvak approved these changes Mar 1, 2024
View reviewed changes
Copy link

@prvak prvak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that with this change the "internal profiling" checkbox is no longer visible when it is disabled in editor settings.

@akien-mga akien-mga merged commit 1e950de into godotengine:master Mar 1, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@prvak prvak prvak approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Profiler "Display internal functions" checkbox disappears
4 participants
@reach-satori @akien-mga @prvak @AThousandShips