Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when getting a C# Resource within a C# Resource in GDScript #91054

Open
mika10095 opened this issue Apr 23, 2024 · 7 comments
Open

Error when getting a C# Resource within a C# Resource in GDScript #91054

mika10095 opened this issue Apr 23, 2024 · 7 comments

Comments

@mika10095
Copy link

Tested versions

  • Reproducible in: 4.2.2-rc2 up to 4.3-dev2 - Not reproducible in: 4.2.1-stable, 4.2.2-rc1, 4.3-dev3 to 4.3-dev5

System information

Godot v4.2.2.stable.mono - Windows 10.0.19045 - Vulkan (Mobile) - dedicated NVIDIA GeForce MX230 (NVIDIA; 30.0.15.1169) - Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz (8 Threads)

Issue description

After updating my project from 4.2.1-stable to 4.2.2-stable I've found that the project doesn't work anymore.
The problem seemingly comes from the fact that I have a Resource within a Resource. I think it is C# Specific. I havent tried making a MRP in GDScript.
error

Steps to reproduce

Open up the project. Build C#. Reload Current Project.

Minimal reproduction project (MRP)

GlobalClassResourceMinRepro.zip

@paulloz
Copy link
Member

paulloz commented Apr 23, 2024

@akien-mga: as far as I can tell, the fix was in #85239.

@akien-mga
Copy link
Member

@akien-mga: as far as I can tell, the fix was in #85239.

I tested cherry-picking it in akien-mga@c89dd76, but that doesn't seem to resolve the issue with the MRP for me.

@paulloz
Copy link
Member

paulloz commented Apr 23, 2024

Arf, my bad, indeed. I probably mishandled something, and ended up with a working build somehow 🙄

@akien-mga
Copy link
Member

I bisected the regression to 9f4eac8 / #85703, CC @TitanNano @godotengine/gdscript.

@raulsntos
Copy link
Member

It looks like the fix was #85215.

@akien-mga
Copy link
Member

It looks like the fix was #85215.

Confirmed, cherry-picking it fixes the issue. It's closely related to #85239, so I guess we have two options:

WDYT?

@paulloz
Copy link
Member

paulloz commented Apr 23, 2024

It looks like the fix was #85215.

I think I matched to commit I bisected onto to the wrong PR because they are by the same author, only a few days apart, and have very similar titles 😭 I now learned there's a tiny link on commit pages that sends you directly to the associated PR. The more you know.

@akien-mga akien-mga self-assigned this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants