Make GDScriptAnalyzer aware of properties from other languages

[TitanNano]

GDScript's auto-completion is aware of properties from scripts in other languages (integrated via GDExtensions) but the GDScript analyzer will report the property as unknown.

The analyzer only ever checks the GDScript class and the native-type of an object for properties. The script type is currently ignored.

(this fix should also be compatible with at least 4.2 and 4.1)

[vnen]

Looks good, but I think it should also look for methods and signals.

[TitanNano]

Looks good, but I think it should also look for methods and signals.

@vnen Methods are already handled somewhere else:

godot/modules/gdscript/gdscript_analyzer.cpp

Line 5006 in d76c1d0

MethodInfo info = base_script->get_method_info(function_name);

I can add signals, though. Should I also add constants here?

[vnen]

Methods are already handled somewhere else:

That is for direct calls. Methods can also be accessed like properties, which return a Callable.

I can add signals, though. Should I also add constants here?

Yes, constants should be included too.

[adamscott]

@TitanNano Hi and welcome around! Thanks for your PR, by the way.

Could you join a simple test project? I'm wondering how we could test this PR before merging it.

[vnen]

I think the easiest way to test is with C#, since it's already integrated in Godot.

[TitanNano]

@TitanNano Hi and welcome around! Thanks for your PR, by the way.

Could you join a simple test project? I'm wondering how we could test this PR before merging it.

Do you have any pointers for me on how to get started with testing this? Especially with the mix of C# and GDScript.

[vnen]

Looks good to me. I did test this with a C# project and it seems to work well.

[vnen]

LGTM. Thanks for working on this!

[AThousandShips]

Just some minor style nits, looks good otherwise

[TitanNano]

@AThousandShips I applied your suggestions. Perhaps this can get merged then?

[YuriSizov]

Thanks, and congrats on your first merged Godot contribution!

PS. For future PRs, please make sure to follow the preferred style for commit messages (starting with a verb, etc). The title of the PR right now is a good option. You also don't need to include reviewers as co-authors 🙂

[TitanNano]

@YuriSizov thank you for the message. How do I backport / cherry-pick this for 4.2 and 4.1? Do I just open pull requests against these branches with a reference to this PR? I wasn't able to find specific documentation.

[YuriSizov]

@TitanNano You don't need to do anything if it's cherry-pickable without conflicts, we'll handle it. That said, the team hasn't expressed yet if this should be cherry-picked.

[DavidVonDerau]

I'm not sure if this is related to this PR or not, but I was going through the commits that went into 4.3 and this seemed like a possible source of the following regression.

---

In 4.2.stable, the following works w/ type checking disabled:

where Multiply is just an example method defined as

If I enable type checking in 4.2.stable, I get the same warning that prompted this PR:

But if I use the 4.3.dev1 release containing this PR, I see the following error:

This is a parse error, so I can't just disable warnings.

I can get the code to parse correctly by using call, like so:

But this doesn't match the documentation on how cross-script method calls should work, and this is not backwards compatible with how it worked in 4.2 -- https://docs.godotengine.org/en/stable/tutorials/scripting/cross_language_scripting.html

[TitanNano]

@DavidVonDerau there is #86259 which should fix this problem.

[akien-mga]

Cherry-picked for 4.2.2.