Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An AnimationPlayer controlling another AnimationPlayer ignores the first loop of the animation #91956

Closed
theraot opened this issue May 14, 2024 · 2 comments

Comments

@theraot
Copy link
Contributor

theraot commented May 14, 2024

Tested versions

  • Reproducible in: v4.3.dev6.official [89850d5]
  • Not reproducible in: v4.3.dev5.official [89f70e9]

System information

Godot v4.3.dev6 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1050 Ti (NVIDIA; 31.0.15.5244) - Intel(R) Core(TM) i3-10105 CPU @ 3.70GHz (8 Threads)

Issue description

The issue arrises from the setup I mention in godotengine/godot-proposals#9712

For abstract: I'm using an AnimationPlayer that controls another AnimationPlayer to add tracks to an imported animation without modifying it.

Steps to reproduce

  • Set an AnimationPlayer with a looping Animation (either created in editor or imported).
  • Set another AnimationPlayer with another Animation, with an Animation Playback Track that triggers the Animation in the first AnimationPlayer. Make this second animation also a looping Animation.
  • Play the Animation from the second AnimationPlayer (the one that controls the other one with an Animation Playback Track).

Result: Playing the Animation from the AnimationPlayer that controls the other one will result in the initial pose frozen until one loop is completed. Afterwards the animation loops correctly.

This is a regression in Godot v4.3.dev6.

Minimal reproduction project (MRP)

animation_wrong.zip

Note: I initially encountered the issue with an imported animation from an FBX. While it is not evident with the cube I used in the minimal reproduction project above, I assure you that it is not simply the animation not playing, instead that the initial pose is held.

@matheusmdx
Copy link
Contributor

Bisecting points to #89794 as the culprit:

image

@theraot
Copy link
Contributor Author

theraot commented May 22, 2024

I got some time to look into this, so I got a build from the master branch (v4.3.beta.custom_build [2149682]) and... It seems to be fixed, so I'm closing this.

@theraot theraot closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Unassessed
Development

No branches or pull requests

4 participants