Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AnimationPlaybackTrack seeking behavior overall #89794

Merged
1 commit merged into from
Mar 24, 2024

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Mar 23, 2024

This is a combined and slightly modified (especially for about #86298) PR of the above three, as they do not work well in separate pieces.

It should be reworked by godotengine/godot-proposals#8783 in the future, but I consider this sufficient to eliminate the inconvenience as a bridge until then.

Co-authored-by: @jsjtxietian, @Miguel0312, @BruceLiCong

@TokageItLab TokageItLab added this to the 4.3 milestone Mar 23, 2024
@TokageItLab TokageItLab requested a review from a team as a code owner March 23, 2024 03:31
@TokageItLab TokageItLab changed the title Fix AnimationPlaybackSeek behavior overall Fix AnimationPlayback seeking behavior overall Mar 23, 2024
@TokageItLab TokageItLab changed the title Fix AnimationPlayback seeking behavior overall Fix AnimationPlaybackTrack seeking behavior overall Mar 23, 2024
@TokageItLab TokageItLab force-pushed the animationplayback-seek branch from 33011a0 to 51781ec Compare March 23, 2024 03:34
@TokageItLab TokageItLab added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 23, 2024
@TokageItLab TokageItLab force-pushed the animationplayback-seek branch from 51781ec to b92ceae Compare March 23, 2024 09:46
Co-authored-by: jsjtxietian <jsjtxietian@outlook.com>
Co-authored-by: Miguel0312 <miguel.vpereira14@gmail.com>
Co-authored-by: BruceLiCong <citb_li@163.com>
@TokageItLab TokageItLab force-pushed the animationplayback-seek branch from b92ceae to c1741fe Compare March 23, 2024 09:48
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@akien-mga akien-mga closed this pull request by merging all changes into godotengine:master in 06abc86 Mar 24, 2024
akien-mga added a commit that referenced this pull request Mar 24, 2024
Fix AnimationPlaybackTrack seeking behavior overall
@akien-mga
Copy link
Member

Thanks!

@TokageItLab TokageItLab deleted the animationplayback-seek branch April 5, 2024 01:33
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants