-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AnimationPlaybackTrack seeking behavior overall #89794
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
changed the title
Fix AnimationPlaybackSeek behavior overall
Fix AnimationPlayback seeking behavior overall
Mar 23, 2024
TokageItLab
changed the title
Fix AnimationPlayback seeking behavior overall
Fix AnimationPlaybackTrack seeking behavior overall
Mar 23, 2024
TokageItLab
force-pushed
the
animationplayback-seek
branch
from
March 23, 2024 03:34
33011a0
to
51781ec
Compare
TokageItLab
added
the
cherrypick:4.2
Considered for cherry-picking into a future 4.2.x release
label
Mar 23, 2024
TokageItLab
force-pushed
the
animationplayback-seek
branch
from
March 23, 2024 09:46
51781ec
to
b92ceae
Compare
Co-authored-by: jsjtxietian <jsjtxietian@outlook.com> Co-authored-by: Miguel0312 <miguel.vpereira14@gmail.com> Co-authored-by: BruceLiCong <citb_li@163.com>
TokageItLab
force-pushed
the
animationplayback-seek
branch
from
March 23, 2024 09:48
b92ceae
to
c1741fe
Compare
akien-mga
approved these changes
Mar 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This was referenced Mar 23, 2024
akien-mga
closed this pull request by merging all changes
into
godotengine:master
in
Mar 24, 2024
06abc86
akien-mga
added a commit
that referenced
this pull request
Mar 24, 2024
Fix AnimationPlaybackTrack seeking behavior overall
Thanks! |
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Considered for cherry-picking into a future 4.2.x release
label
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_blend_process
#89771This is a combined and slightly modified (especially for about #86298) PR of the above three, as they do not work well in separate pieces.
It should be reworked by godotengine/godot-proposals#8783 in the future, but I consider this sufficient to eliminate the inconvenience as a bridge until then.
Co-authored-by: @jsjtxietian, @Miguel0312, @BruceLiCong