Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Animation Playback Track not Seeking Properly #89736

Closed
wants to merge 1 commit into from
Closed

Fix Animation Playback Track not Seeking Properly #89736

wants to merge 1 commit into from

Conversation

BruceLiCong
Copy link
Contributor

Reapply bugfix #38107

@BruceLiCong BruceLiCong requested a review from a team as a code owner March 21, 2024 09:01
@BruceLiCong

This comment was marked as off-topic.

Sign in to view
@Zireael07

This comment was marked as off-topic.

Sign in to view
TokageItLab
TokageItLab approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the regression was caused by #80813 because the fix in #38107 was applied to AnimationPlayer but not to AnimationTree since the AnimationMixer was implemented based on the AnimationTree.

However, there are many other potential problems with the AnimationPlaybackTrack, so we are planning to rework the playback process of AnimationPlaybackTrack in the future as godotengine/godot-proposals#8783.

Well, this fix might fine for 4.3.

@TokageItLab TokageItLab added this to the 4.3 milestone Mar 21, 2024
@BruceLiCong
Copy link
Contributor Author

It seems that the regression was caused by #80813 because the fix in #38107 was applied to AnimationPlayer but not to AnimationTree since the AnimationMixer was implemented based on the AnimationTree.

However, there are many other potential problems with the AnimationPlaybackTrack, so we are planning to rework the playback process of AnimationPlaybackTrack in the future as godotengine/godot-proposals#8783.

Well, this fix might fine for 4.3.

Thanks for the updates!

@TokageItLab TokageItLab mentioned this pull request Mar 23, 2024
Merged
@akien-mga
Copy link
Member

Superseded by #89794. Thanks for the contribution!

@akien-mga akien-mga closed this Mar 23, 2024
@akien-mga akien-mga removed this from the 4.3 milestone Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TokageItLab TokageItLab TokageItLab approved these changes

Assignees
No one assigned
Labels
archived bug regression topic:animation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BruceLiCong @Zireael07 @akien-mga @TokageItLab