Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Animation Playback Track not seeking properly #38107

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Fix Animation Playback Track not seeking properly #38107

merged 1 commit into from
Sep 15, 2021

Conversation

EspeuteClement
Copy link
Contributor

@EspeuteClement EspeuteClement commented Apr 22, 2020 •
edited by akien-mga
Loading

This is a fix for the issue #38093
This fix has been tested in both the master and the 3.2 branch.

The fix is in two parts :

  1. A typo where a MAX function was used instead of a MIN function
  2. Forcing the animation to play from the start when the first Key of the animation is encountered

Bugsquad edit: Fixes #38093.

@Calinou Calinou added this to the 4.0 milestone Jan 5, 2021
@YuriSizov YuriSizov requested a review from a team August 24, 2021 23:09
@reduz
Copy link
Member

reduz commented Aug 30, 2021

Looks good, although it will have to be rebased.

@akien-mga
Copy link
Member

I force-pushed a rebase so that this can be merged.

@akien-mga akien-mga merged commit f2c4494 into godotengine:master Sep 15, 2021
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 15, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 21, 2021
BruceLiCong added a commit to BruceLiCong/godot that referenced this pull request Mar 21, 2024
@BruceLiCong
Fix Animation Playback Track not seeking properly
7adfba5 
Reapply bugfix godotengine#38107
@BruceLiCong BruceLiCong mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reduz reduz reduz approved these changes

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug topic:animation topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Animation Playback Track not seeking properly in the Animation Editor
6 participants
@EspeuteClement @reduz @akien-mga @Calinou @aaronfranke @bojidar-bg