Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditorExportPlugin: Error when customizing "Keep File" resources #93825

Closed
allenwp opened this issue Jul 1, 2024 · 0 comments · Fixed by #93878
Closed

EditorExportPlugin: Error when customizing "Keep File" resources #93825

allenwp opened this issue Jul 1, 2024 · 0 comments · Fixed by #93878
Labels
bug topic:editor topic:export
Milestone
4.3

Comments

@allenwp
Copy link
Contributor

allenwp commented Jul 1, 2024

Tested versions

  • Reproducable in v4.3.beta2.official [b75f048], v4.2.1.stable.official [b09f793], v4.0.stable.official [92bee43]

System information

Godot v4.3.beta2 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 980 Ti (NVIDIA; 31.0.15.3699) - Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 Threads)

Issue description

When customizing resources (returning true from _begin_customize_resources of an EditorExportPlugin), resources that are imported as "Keep File (exported as is)" cause the following sort of error message:

Resource file not found:  (expected type: )
Failed loading resource: res://test-icon.svg. Make sure resources have been imported by opening the project in the editor at least once.
editor/export/editor_export_platform.cpp:832 - Condition "res.is_null()" is true. Returning: p_path

Steps to reproduce

  1. Create an EditorExportPlugin
  2. Return true from _begin_customize_resources
  3. Change a Texture2D's import configuration to Import As: Keep File (exported as is)
  4. Export the project or a PCK/ZIP

Alternatively:

  1. Open MRP
  2. Export the project or a PCK/ZIP

Minimal reproduction project (MRP)

Testxport-keep-file-error.zip
@allenwp allenwp mentioned this issue Jul 3, 2024
Merged
allenwp added a commit to allenwp/godot that referenced this issue Jul 3, 2024
@allenwp
Moved logic surrounding "Skip" and "Keep" imported files to happen be…
460e486 
…fore resource customization. Fixes godotengine#93825
@akien-mga akien-mga added this to the 4.3 milestone Jul 5, 2024
sorascode pushed a commit to sorascode/godot-soras-version that referenced this issue Jul 22, 2024
@allenwp @sorascode
EditorExportPlugin: Call _export_file for all resource types
32f4742 
- Alternate fix to godotengine#67844 that calls `_export_file` for all resource types instead of implementing `skip()` for customize functions.
- Fixes godotengine#93823.
- Moved logic surrounding "Skip" and "Keep" imported files to happen before resource customization. Fixes godotengine#93825.
- Also fixes an issue that I suspect might exist where progress bars during export were incorrect due to imported files in the project that are configured as "Keep" or "Skip".
Luis-Wong pushed a commit to Luis-Wong/godot that referenced this issue Jul 26, 2024
@allenwp @Luis-Wong
EditorExportPlugin: Call _export_file for all resource types
498bad0 
- Alternate fix to godotengine#67844 that calls `_export_file` for all resource types instead of implementing `skip()` for customize functions.
- Fixes godotengine#93823.
- Moved logic surrounding "Skip" and "Keep" imported files to happen before resource customization. Fixes godotengine#93825.
- Also fixes an issue that I suspect might exist where progress bars during export were incorrect due to imported files in the project that are configured as "Keep" or "Skip".
2nafish117 pushed a commit to 2nafish117/godot that referenced this issue Aug 5, 2024
@allenwp @2nafish117
EditorExportPlugin: Call _export_file for all resource types
277d3d5 
- Alternate fix to godotengine#67844 that calls `_export_file` for all resource types instead of implementing `skip()` for customize functions.
- Fixes godotengine#93823.
- Moved logic surrounding "Skip" and "Keep" imported files to happen before resource customization. Fixes godotengine#93825.
- Also fixes an issue that I suspect might exist where progress bars during export were incorrect due to imported files in the project that are configured as "Keep" or "Skip".
chryan pushed a commit to chryan/godot that referenced this issue Aug 6, 2024
@allenwp @chryan
EditorExportPlugin: Call _export_file for all resource types
7795b84 
- Alternate fix to godotengine#67844 that calls `_export_file` for all resource types instead of implementing `skip()` for customize functions.
- Fixes godotengine#93823.
- Moved logic surrounding "Skip" and "Keep" imported files to happen before resource customization. Fixes godotengine#93825.
- Also fixes an issue that I suspect might exist where progress bars during export were incorrect due to imported files in the project that are configured as "Keep" or "Skip".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:editor topic:export
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

EditorExportPlugin: Call _export_file for all resource types allenwp/godot
3 participants
@KoBeWi @akien-mga @allenwp