Updating from 4.2 to 4.3 overwrites Settings

[inhalt120g]

Tested versions

v4.3.beta2.official [b75f048]

System information

Newest macOS

Issue description

I was using 4.2 until recently, and switched to v4.3.beta2.official [b75f048] a few weeks ago. Usually, such upgrades would carry over all the settings from old Godot builds, but this time at least one setting was overwritten with new build (I have the "Text Editor / Completion / Add Type hints" set to "off", but the new build set it to "on").

There might be other settings that got overwritten (this one was easy to spot).

Edit 1: Another thing that got overwritten is at least one of the custom theme colors, for example now I noticed orange color is used in some places.

Edit 2: …and some keyboard shortcuts got "fixed" too :PPPP

Steps to reproduce

Download the newest build, overwrite the old build in the Apps directory? Not sure. This never happened when I was upgrading from 4.1 to later builds.

Minimal reproduction project (MRP)

v4.3.beta2.official [b75f048]

[Calinou]

but this time at least one setting was overwritten with new build (I have the "Text Editor / Completion / Add Type hints" set to "off", but the new build set it to "on").

This is because default values are not saved to editor settings. Since the default was previously false and it became true in #88026, it became true in your installation because your editor_settings-4.tres file previously did not have a setting stored for the Add Type Hints editor setting (unless it was true).

That said, this won't happen in the future anymore because editor settings are versioned per minor editor version since 4.3: #90875

[inhalt120g]

I understand the explanation and am happy it's not supposed to happen in the future, it's a nuisance. Thank you for linking the relevant issues and providing the info!