Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a folder that contains a file is not removed from the FileSystem Dock #94431

Closed
Hilderin opened this issue Jul 16, 2024 · 3 comments · Fixed by #94435
Closed

Removing a folder that contains a file is not removed from the FileSystem Dock #94431

Hilderin opened this issue Jul 16, 2024 · 3 comments · Fixed by #94435

Comments

@Hilderin
Copy link
Contributor

Hilderin commented Jul 16, 2024

Tested versions

  • Reproducible in 4.3.beta.mono (97b8ad1)
  • Reproducible in 4.3 beta 3
  • Not reproducible in 4.3 beta 2
  • Not reproducible in 4.3 beta 1
  • Not reproducible in 4.2.1

System information

Godot v4.3.beta3 - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 (NVIDIA; 31.0.15.3742) - 11th Gen Intel(R) Core(TM) i5-11600KF @ 3.90GHz (12 Threads)

Issue description

When deleting a folder using the FileSystem Dock, if the folder contains a file, everything is deleted on the disk, but in the FileSystem in the editor, onyl the file disappear. I need to restart the editor for the folder to disappear.

Steps to reproduce

  • Create a folder
  • Create a scene in it
  • Delete the folder in Godot

Minimal reproduction project (MRP)

Any project.

@sci-comp
Copy link

sci-comp commented Jul 16, 2024

This also happens with files for me. It's not 100% reproducible, but more often than not, I do end up having to reload the entire project as a way to force a rescan of all files (which seems to take significantly longer in 4.3 beta3, but I guess that's a separate issue).

Edit: Also, often creating a new file will not show up as well in the FileSystem.

image

@Hilderin
Copy link
Contributor Author

Hilderin commented Jul 16, 2024

@sci-comp
Unfortunately, I did not encounter the same problem with files on my side. Did you found a pattern to reproduce the problem or maybe some actions where it happens more often like renaming, removing files; in or out of the editor?

Oh, and for the problem where the scan takes longer, can you creates an separate issue for that with the difference between versions and an MRP. Thanks.

@sci-comp
Copy link

sci-comp commented Jul 17, 2024

@Hilderin

I tried to reproduce the file error I mentioned above in a new project, but I'm unable. I added a large number of cubes from Blender thinking that a lot of clutter might help, but it does not.

I am able to reproduce the folder issue you've mentioned, however,

2024-07-16.20-11-29.mp4

I will make a new issue regarding experiencing longer file system scan times if I'm able to provide more details. I think an MRP for this possible issue will need to be very large. With 200 cubes in this current example, file system scans are instant in my tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants