Fix removing a folder that contains a file is not removed from the FileSystem Dock #94435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hilderin
force-pushed
the
fix-removing-folder-with-files
branch
from
c5e6578
to
a1ef54f
Compare
|
Might also fix #93097 |
akien-mga
approved these changes
Jul 17, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is a side-effect from #92303. To be able to manage correctly the removing of scripts with global class names, I added all removed files in
scan_actionswith the actionACTION_FILE_REMOVE. But in_update_scene_groupsor_update_script_documentationthe methodfind_fileis called, which calls_find_file. The method_find_filerecreates the parent folder of the searched file if it does not exist infilesystem.I added a check to prevent adding a folder in
filesystemthat does not exist on the disk.