Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4 Dev 2 - Quest 3] Enabling xr/openxr/enabled.editor in OpenXR causes flatscreen editor to update at 1fps on Quest 3 #96831

Closed
JD-The-65th opened this issue Sep 10, 2024 · 4 comments · Fixed by #96868

Comments

@JD-The-65th
Copy link

JD-The-65th commented Sep 10, 2024

Tested versions

  • Reproducible in 4.4 dev 2

System information

Godot v4.4.dev2 - Android - OpenGL ES 3 (Compatibility) - Adreno (TM) 740 - (6 Threads)

Issue description

In both Compatibility and Mobile renderer, setting enabled.editor to true in OpenXR settings causes the flatscreen editor to update at 1fps, but the XR player continues at normal speed.

Steps to reproduce

  1. Install Godot 4.4 dev 2 on Quest 3
  2. Make a new project
  3. Set enabled.editor to true in OpenXR Project settings
  4. Restart the Editor.
  5. Observe.

Minimal reproduction project (MRP)

No MRP needed.

@JD-The-65th JD-The-65th changed the title [4.4 Dev 2 - Quest 3] Enabling '''enabled.editor''' in OpenXR causes flatscreen editor to update at 1fps on Quest 3 [4.4 Dev 2 - Quest 3] Enabling enabled.editor in OpenXR causes flatscreen editor to update at 1fps on Quest 3 Sep 10, 2024
@BastiaanOlij
Copy link
Contributor

cc @m4gr3d @dsnopek

@akien-mga akien-mga changed the title [4.4 Dev 2 - Quest 3] Enabling enabled.editor in OpenXR causes flatscreen editor to update at 1fps on Quest 3 [4.4 Dev 2 - Quest 3] Enabling xr/openxr/enabled.editor in OpenXR causes flatscreen editor to update at 1fps on Quest 3 Sep 11, 2024
@akien-mga akien-mga added this to the 4.4 milestone Sep 11, 2024
@dsnopek
Copy link
Contributor

dsnopek commented Sep 11, 2024

I am able to reproduce this.

However, I feel like xr/openxr/enabled.editor shouldn't need to be enabled in order to launch XR apps from the editor, yet it seems to be in my testing. I'm not sure what changed since I last tested PR #96624, but I'm digging into it.

@akien-mga
Copy link
Member

I am able to reproduce this.

However, I feel like xr/openxr/enabled.editor shouldn't need to be enabled in order to launch XR apps from the editor, yet it seems to be in my testing. I'm not sure what changed since I last tested PR #96624, but I'm digging into it.

When you tested it, xr/openxr/enabled.editor was never defined so I'm not sure what it returned.
It was defined in #96780 to fix the startup error about it.

@dsnopek
Copy link
Contributor

dsnopek commented Sep 11, 2024

I just posted PR #96868 which fixes launching XR apps without enabling xr/openxr/enabled.editor. It doesn't fix the flatscreen editor updating at 1FPS, but it removes the need to enable xr/openxr/enabled in the first place

UPDATE: In the latest version of my PR, it does completely fix this issue by removing the problematic Project Setting altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants