-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android editor] Improve support for XR projects #96624
[Android editor] Improve support for XR projects #96624
Conversation
5dfae9a
to
33caabd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested on the Meta Quest 3, both with a flatscreen app and an immersive XR app. Everything seems to be working great!
The code looks good to me too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, you weren't kidding, I was expecting much more invasive changes. This creates a really nice platform to expand upon.
33caabd
to
a54accb
Compare
platform/android/java/editor/src/main/java/org/godotengine/editor/BaseGodotEditor.kt
Show resolved
Hide resolved
platform/android/java/editor/src/main/java/org/godotengine/editor/BaseGodotEditor.kt
Outdated
Show resolved
Hide resolved
platform/android/java/editor/src/main/java/org/godotengine/editor/EditorMessageDispatcher.kt
Outdated
Show resolved
Hide resolved
horizonos:minSdkVersion="69" | ||
horizonos:targetSdkVersion="69" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
boolean debugSymbols = devBuild || isAndroidStudio() | ||
boolean debugSymbols = devBuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily for this PR, but I think the back and forth on this shows that we need a dedicated option for enabling debug symbols in gradle, and not just infer it from dev
or debug symbols.
It should be possible for users to make template_release
and template_debug
builds with debug symbols, to be stripped when uploading their builds, so they can symbolicate crashes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really clean and the refactor makes sense to properly support multiple flavors of the Android editor.
Can't test it for now as I believe my dusty Quest 1 doesn't have a recent enough OS version for this :D
a54accb
to
9dc0543
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, working great on my Quest 3!
Thanks to everyone involved! That's a pretty exciting change, I'm eager to see more of what it will enable :) |
Please post screenshots or videos of the editor working in Quest 3 with some demos. We are very curious! P.S.: Is there any chance it could work in Quest 2? |
We'll make some videos after not too long - this is just the beginning. :-) It can "work" on the Quest 2, however, it's a little under-powered and doesn't provide as good an experience as Quest 3 and Quest Pro, so we decided not to support it, at least for now - perhaps we'll be able to optimize and improve the experience in the future. However, if want to build it yourself and allow it to run on Quest 2, you just need to change this line in the |
Port the Android editor to Meta Quest (HorizonOS) devices:
Note: Requires Horizon OS v69 or higher