Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Android editor builds for Meta devices #100

Merged

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Sep 5, 2024

Copy link

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it, but the gradle command and the build artifact paths look good to me.

Copy link

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

build-android/build.sh Outdated Show resolved Hide resolved
build-android/build.sh Outdated Show resolved Hide resolved
build-android/build.sh Outdated Show resolved Hide resolved
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but I think I'll rework this further to add more configuration options for this script.

It's predominantly meant for our official builds, and thus fine as is, but a lot of people also try to use it to make their own builds of Godot, and they won't care to build the Android editor for either Google Play or Horizon Store IMO, so we can make it optional.

This would help improve the usability around the whole store_release and keystore config, which can be hard to get right for those users.

@akien-mga akien-mga merged commit fa404f8 into godotengine:main Sep 8, 2024
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the add_support_for_godot_meta_editor_builds branch September 8, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants