-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Android editor builds for Meta devices #100
Add support for Android editor builds for Meta devices #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test it, but the gradle command and the build artifact paths look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, but I think I'll rework this further to add more configuration options for this script.
It's predominantly meant for our official builds, and thus fine as is, but a lot of people also try to use it to make their own builds of Godot, and they won't care to build the Android editor for either Google Play or Horizon Store IMO, so we can make it optional.
This would help improve the usability around the whole store_release
and keystore config, which can be hard to get right for those users.
Thanks! |
Requires godotengine/godot#96624