Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4 backport] Android editor improvements, Meta XR editor #92

Merged

Conversation

jss2a98aj
Copy link
Member

@jss2a98aj jss2a98aj commented Oct 23, 2024

Backports android editor improvements, along with the Meta XR editor. I do not have a Quest to test this with, so someone that has one will need to do that. Marked as a draft until someone with appropriate hardware can test it.
See
godotengine#91271 godotengine#94799
godotengine#93526 godotengine#95700
godotengine#96254 godotengine#96208
godotengine#96340 godotengine#96365
godotengine#96624

m4gr3d and others added 13 commits October 23, 2024 16:42
- Returns an empty list when there's not registered plugins, thus preventing the creation of spurious iterator objects

- Inline `Godot#getRotatedValues(...)` given it only had a single caller. This allows to remove the allocation of a float array on each call and replace it with float variables

- Disable sensor events by default. Sensor events can fired at 10-100s Hz taking cpu and memory resources. Now the use of sensor data is behind a project setting allowing projects that have use of it to enable it, while other projects don't pay the cost for a feature they don't use

- Create a pool of specialized input `Runnable` objects to prevent spurious, unbounded `Runnable` allocations

- Disable showing the boot logo for Android XR projects

- Delete locale references of jni strings
…roid apks

Update the export logic to enable apk generation and signing for Android editor builds

Note: Only legacy builds are supported. Gradle builds are not supported at this point in time.
In `godot-build-scripts`, the default `config.sh` sets `GODOT_ANDROID_SIGN_KEYSTORE` to an empty string but we were only checking if it's null.
@jss2a98aj jss2a98aj marked this pull request as draft October 23, 2024 21:04
@jss2a98aj jss2a98aj marked this pull request as ready for review October 24, 2024 00:14
Copy link

@Starkium Starkium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it deployed and working on a quest 3. File system feels like it needs a performance boost, everything else seems to work fine.

@Starkium Starkium merged commit 3d368f6 into blazium-engine:blazium-dev Oct 24, 2024
22 checks passed
@DeanLemans
Copy link

Any planned support for meta quest 2?

@jss2a98aj jss2a98aj deleted the cherry-pick-4.4-android-xr-editor branch October 30, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants