[Net] Fix TCP/UDP server network tests #100107
Merged
+123
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests have been removed since there's no way to guarantee they will pass. Other tests have been refactored to ensure proper waiting, and taking into account potential out-of-order delivery (which is unlikely in test scenarios but expecting a specific order on a UDP socket is wrong and OSes makes no promises of ordered delivery on localhost).
Faless
commented
Dec 6, 2024
| namespace TestTCPServer { | ||
|
|
||
| const int PORT = 12345; | ||
| const IPAddress LOCALHOST("127.0.0.1"); | ||
| const uint32_t SLEEP_DURATION = 1000; | ||
| const uint64_t MAX_WAIT_USEC = 100000; | ||
| const uint64_t MAX_WAIT_USEC = 2000000; |
There was a problem hiding this comment.
I raised this so we could also test the timeout functionality when testing the connection to a server that is not listening.
This should not affect the timing of other tests unless they fail, but we can maybe make this a parameter of wait_for_condition and only have the higher value in that specific test.
|
Thanks for taking care of this! |
akien-mga
approved these changes
Feb 6, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests have been removed since there's no way to guarantee they will pass.
Other tests have been refactored to ensure proper waiting, and taking into account potential out-of-order delivery (which is unlikely in test scenarios but expecting a specific order on a UDP socket is wrong and OSes makes no promises of ordered delivery on localhost).