Fix wide SpotLight3D clustering
#100236
Merged
Fix wide SpotLight3D clustering
#100236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
approved these changes
Dec 13, 2024
Flarkk
force-pushed
the
fix_spot_clustering
branch
from
eb8e0d6 to
02f05cf
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89698
Fixes #81772
Wide spotlights are expected to be clustered like omni lights.
Currently they're correctly rendered as spheres with the right radius (like omnis) but intersection with near and far planes is still checked against a cone volume. This generate false positive or missed hits depending on the camera's location relative to the spotlight, znear and zfar values.
This PR ensures wide spotlights get tested against near and far planes using a sphere like omnis, by using the same code branch.