OpenXR: Fix crash with composition layers in non-dev builds #100471
Merged
+2
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash that happens when using OpenXR composition layers, but only on non-dev builds (which is why I didn't notice it right away) and only when the fallback is used because the OpenXR runtime doesn't support a type of layer (I encountered this with the Meta XR Simulator, which supports quad and cylinder layers, but not equirect layers - this sample uses all layer types and can reproduce the issue).
The new code is a lot simpler too!
The issue was introduced by PR #96185 (sorry!) and present in all 4.4 dev releases since 4.4-dev2