Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makeper_pixel_transparency enabled by default #101252

Closed
wants to merge 1 commit into from

Conversation

YeldhamDev
Copy link
Member

The logical next step now that #91333 is merged.

Technically a compatibility break, since this changes a default project setting.

@YeldhamDev YeldhamDev added this to the 4.4 milestone Jan 8, 2025
@YeldhamDev YeldhamDev requested a review from a team as a code owner January 8, 2025 00:24
@YeldhamDev YeldhamDev requested a review from a team as a code owner January 8, 2025 00:26
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth overriding it for the editor, but I would not enable it for the projects.

Projects use embedded windows by default, so it's useless and can add unnecessary overhead.

@clayjohn
Copy link
Member

clayjohn commented Jan 8, 2025

Are popup shadows something that are worth slowing down the editor for?

@mrjustaguy
Copy link
Contributor

IMO no.

@Mickeon
Copy link
Contributor

Mickeon commented Jan 8, 2025

Some users regard the editor as being somewhat sluggish as is, so if this is changed by default it would be nice to address the few other pain points first. We now allow V-sync to be disabled in the editor for similar reasons, I think?

@YeldhamDev
Copy link
Member Author

The problem is that the default project theme has popups with shadows and rounded corners, which not just means they look wrong, but also the warning message will display for them.

@Zireael07
Copy link
Contributor

@YeldhamDev: Solution: remove shadows and rounded corners from default theme.

@akien-mga akien-mga changed the title Make "per_pixel_transparency" enabled by default Makeper_pixel_transparency enabled by default Jan 8, 2025
@akien-mga
Copy link
Member

Yeah I don't think we should enable this by default, so we should change the editor theme so that it doesn't use shadows.

As we've seen in #91333 per-pixel transparency for Nvidia on Windows is broken. That's the configuration the vast majority of Godot users has, so we can't have a default editor theme that's broken for them.

In the past we also had significant issues with per-pixel transparency on various drivers, this isn't safe to enable by default just for cosmetic reasons.

@YeldhamDev
Copy link
Member Author

Yeah, I see the point. Closing it.

@YeldhamDev YeldhamDev closed this Jan 8, 2025
@YeldhamDev YeldhamDev deleted the no_rakes_this_time branch January 8, 2025 22:49
@akien-mga akien-mga removed this from the 4.4 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants