-
-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makeper_pixel_transparency
enabled by default
#101252
Conversation
bfdb445
to
4063d3e
Compare
4063d3e
to
e5c7c98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth overriding it for the editor, but I would not enable it for the projects.
Projects use embedded windows by default, so it's useless and can add unnecessary overhead.
Are popup shadows something that are worth slowing down the editor for? |
IMO no. |
Some users regard the editor as being somewhat sluggish as is, so if this is changed by default it would be nice to address the few other pain points first. We now allow V-sync to be disabled in the editor for similar reasons, I think? |
The problem is that the default project theme has popups with shadows and rounded corners, which not just means they look wrong, but also the warning message will display for them. |
@YeldhamDev: Solution: remove shadows and rounded corners from default theme. |
per_pixel_transparency
enabled by default
Yeah I don't think we should enable this by default, so we should change the editor theme so that it doesn't use shadows. As we've seen in #91333 per-pixel transparency for Nvidia on Windows is broken. That's the configuration the vast majority of Godot users has, so we can't have a default editor theme that's broken for them. In the past we also had significant issues with per-pixel transparency on various drivers, this isn't safe to enable by default just for cosmetic reasons. |
Yeah, I see the point. Closing it. |
The logical next step now that #91333 is merged.
Technically a compatibility break, since this changes a default project setting.