Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold resources when object is unedited #102248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jan 31, 2025

Closes #99772
Closes #100152

However this has a side-effect of always closing resources when node is deselected.

godot.windows.editor.dev.x86_64_quRfYBLapw.mp4

The shader editor was opening, because Shader stayed unfolded when switching nodes. This is the only way to fix it, other than reworking how resources are edited.

@akien-mga
Copy link
Member

However this has a side-effect of always closing resources when node is deselected.

That sounds pretty annoying if editing a specific subresource and having to switch between separate node selections to check something. Having to re-unfold everything to go back to where you were a second before would break the flow, no?

@KoBeWi
Copy link
Member Author

KoBeWi commented Feb 12, 2025

The alternative is that your editor may switch to another tab (which happens right now, and which the issue is about), but it's much less common.
Can't say how much if affects workflow, I'd have to test it for a bit, but it depends on what editor do you use.

@rbogdy
Copy link

rbogdy commented Feb 22, 2025

I ran into this issue when working on a shader that was importing a shader include. I attached a small project that replicates this issue.
It seems like the problem does not only happen when chosing another node in the scene tree.

I used v4.4.rc1.official [8ed125b] to test, and I can't replicate the issue in v4.3.stable.official [77dcf97]

Steps:

  1. Select the ColorRect Node in the main scene
  2. Unfold the Material and then unfold the Shader
  3. Open the circle_shader_include, shaderinclude file and delete a letter on line 2. Wait for like a second and you will see how the Bottom Panel jumps back to the color_shader gdshader file

My work around is to fold the Shader panel while having the ColorRect node selected and that will let me work on the errors in the shaderinclude file, without switching.

Project:
BottomPanelBug.zip

EDIT: Forgot to attach the project

@KoBeWi
Copy link
Member Author

KoBeWi commented Feb 22, 2025

That looks like separate issue. I don't see why the Shader would be edited in this case.

EDIT:
I opened #103159

@akien-mga akien-mga modified the milestones: 4.4, 4.5 Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shader editor opening when clicking on node Bottom panel: Shader Editor keeps popping up over Animation tab
3 participants